From: Hugh Dickins <hugh@veritas.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stop ==== emergency
Date: Mon, 6 Feb 2006 08:46:07 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0602060841540.6574@goblin.wat.veritas.com> (raw)
In-Reply-To: <20060205205709.0b88171b.zaitcev@redhat.com>
On Sun, 5 Feb 2006, Pete Zaitcev wrote:
> On Fri, 3 Feb 2006 21:37:09 +0000 (GMT), Hugh Dickins <hugh@veritas.com> wrote:
>
> > +++ linux/arch/i386/kernel/traps.c 2006-02-03 09:59:37.000000000 +0000
> > @@ -166,7 +166,8 @@ static void show_trace_log_lvl(struct ta
> > stack = (unsigned long*)context->previous_esp;
> > if (!stack)
> > break;
> > - printk(KERN_EMERG " =======================\n");
> > + printk(log_lvl);
> > + printk(" =======================\n");
> > }
>
> This is wrong, Hugh. What do you think the priority of the second printk?
> It's not log_lvl, that's for sure.
Are you sure? I've not delved into the printk code itself, but this
does follow the same pattern as in show_stack_log_lvl itself e.g. its
"Call Trace:\n" line. (I am assuming print_context_stack ends with a
newline, as it does.)
Hugh
next prev parent reply other threads:[~2006-02-06 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1139006040.12873.linux-kernel2news@redhat.com>
2006-02-06 4:57 ` Pete Zaitcev
2006-02-06 8:46 ` Hugh Dickins [this message]
2006-02-06 18:55 ` Jean Delvare
2006-02-06 21:11 ` Hugh Dickins
2006-02-06 21:32 ` Pete Zaitcev
2006-02-06 22:15 ` Hugh Dickins
2006-02-03 21:37 Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0602060841540.6574@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®