From: Jesper Juhl <juhl-lkml@dif.dk>
To: Dave Jones <davej@redhat.com>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
Pekka Enberg <penberg@gmail.com>, Paul Jackson <pj@engr.sgi.com>,
rlrevell@joe-job.com, linux-os@analogic.com,
Arjan van de Ven <arjan@infradead.org>,
Denis Vlasenko <vda@ilport.com.ua>,
Jesper Juhl <juhl-lkml@dif.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
Date: Mon, 28 Mar 2005 00:56:53 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0503280033130.2459@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <20050327174026.GA708@redhat.com>
On Sun, 27 Mar 2005, Dave Jones wrote:
> Am I the only person who is completely fascinated by the
> effort being spent here micro-optimising something thats
> almost never in a path that needs optimising ?
> I'd be amazed if any of this masturbation showed the tiniest
> blip on a real workload, or even on a benchmark other than
> one crafted specifically to test kfree in a loop.
>
> That each occurance of this 'optimisation' also saves a handful
> of bytes in generated code is it's only real benefit afaics.
> Even then, if a functions cache performance is better off because
> we trimmed a few bytes from the tail of a function, I'd be
> completely amazed.
>
I agree, it's amazing that this is treated like a big issue, it's not, and
I never meant for it to be a matter of such debate.
The whole thing (viewed from where I'm sitting) started when I noticed a
few of those redundant NULL checks while reading code, thought I'd clean
them up since they were clearly not needed and submit those patches. When
those patches then got merged I thought "ok, so this is something that's
actually appreciated, guess I might as well do some more when I come
across them or maybe even seek them out and get rid of them once and for
all"... So I started doing that and more of the patches got merged which
(at least to me) confirmed that it was a worthwhile activity, until at
some point voices were raised in objection.
At that point I felt I needed to explain the "why" of why I was doing it
and try and show that it might actually be a bennefit (and I believe the
small test I wrote shows it to be either a bennefit in the usual case or
at worst a trivial performance hit in the not-so-common case).
What I'm trying to find out now is if there's a general consensus that
these patches are worthwile and wanted or if they are unwanted and I'm
wasting my time. If the patches are wanted I don't mind doing them, but
if they are not wanted I don't want to waste my time (nor anyone elses) on
them. So, if I could just get peoples comment on that "wanted vs
not-wanted" then I could get on with either producing some patches for
people or get on with other things and drop this... Or I guess I could
just go on making those patches, submit them and then just leave it in the
hands of the individual maintainers (which was more or less how I started
out)...
--
Jesper Juhl
next prev parent reply other threads:[~2005-03-27 22:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 22:08 [PATCH] no need to check for NULL before calling kfree() - fs/ext2/ Jesper Juhl
2005-03-25 22:29 ` linux-os
2005-03-25 22:44 ` Jesper Juhl
2005-03-26 7:50 ` Pekka Enberg
2005-03-26 8:32 ` Arjan van de Ven
2005-03-26 23:21 ` [PATCH] no need to check for NULL before calling kfree() -fs/ext2/ linux-os
2005-03-26 23:34 ` Marcin Dalecki
2005-03-27 2:00 ` Horst von Brand
2005-03-27 3:18 ` Marcin Dalecki
2005-03-27 22:12 ` linux-os
2005-03-26 23:54 ` Jesper Juhl
2005-03-27 0:05 ` Lee Revell
2005-03-27 10:55 ` Jesper Juhl
2005-03-27 14:56 ` Paul Jackson
2005-03-27 15:12 ` Jan Engelhardt
2005-03-27 17:40 ` Dave Jones
2005-03-27 18:17 ` Jan Engelhardt
2005-03-27 19:25 ` Pekka Enberg
2005-03-27 22:56 ` Jesper Juhl [this message]
2005-03-28 4:53 ` Paul Jackson
2005-03-30 18:57 ` Jesper Juhl
2005-03-28 1:20 ` Horst von Brand
2005-03-28 4:10 ` Paul Jackson
2005-03-28 12:58 ` Geert Uytterhoeven
2005-03-29 2:52 ` Lee Revell
2005-03-29 6:30 ` Pekka Enberg
2005-03-29 7:06 ` Jan Engelhardt
2005-03-29 7:24 ` Pekka J Enberg
2005-03-30 2:44 ` Paul Jackson
2005-03-30 6:13 ` Pekka J Enberg
2005-03-30 6:16 ` Paul Jackson
2005-03-30 7:15 ` P Lavin
2005-03-30 14:20 ` Jesper Juhl
2005-03-30 19:10 ` Jesper Juhl
2005-04-09 2:21 ` Jesper Juhl
2005-03-28 4:07 ` [PATCH] " Paul Jackson
2005-03-27 8:45 ` Arjan van de Ven
2005-03-27 12:51 ` Denis Vlasenko
2005-03-27 14:28 ` Arjan van de Ven
2005-03-27 23:13 ` [PATCH] no need to check for NULL before calling kfree()-fs/ext2/ linux-os
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0503280033130.2459@dragon.hyggekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=penberg@gmail.com \
--cc=pj@engr.sgi.com \
--cc=rlrevell@joe-job.com \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®