mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: Paul Jackson <pj@engr.sgi.com>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
	davej@redhat.com, jengelh@linux01.gwdg.de, penberg@gmail.com,
	rlrevell@joe-job.com, linux-os@analogic.com, arjan@infradead.org,
	vda@ilport.com.ua, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
Date: Wed, 30 Mar 2005 20:57:24 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.62.0503302053100.2463@dragon.hyggekrogen.localhost> (raw)
In-Reply-To: <20050327205334.14a7b3c4.pj@engr.sgi.com>


Hi Paul,

Sorry about the late reply.


On Sun, 27 Mar 2005, Paul Jackson wrote:

> Jesper wrote:
> > What I'm trying to find out now is if there's a general consensus that 
> > these patches are worthwile and wanted or if they are unwanted and I'm 
> > wasting my time. 
> 
> Thanks for your good work so far, and your good natured tolerance of
> the excessively detailed discussions resulting.
> 
> I don't have a big preference either way - but a couple of questions:
> 
>  1) Do you have any wild guess of how many of these you've done so far,
>     and how many potentially remain that could be done?  Tens, hundreds,
>     thousands?
> 
That would indeed be a wild guess, I guess I've done somewhere inbetween 
50 and 200 so far, and I guess there's probably somewhere around 1-2000 
left... but, I'm guessing.


>  2) Any idea what was going on with the numbers you posted yesterday,
>     which, at least from what I saw at first glance, seemed to show
>     "if (likely(p)) kfree(p);" to be a good or best choice, for all
>     cases, including (p != NULL) being very unlikely?  That seemed
>     like a weird result.
> 
> If the use of "likely(p)" is almost always a winner, then the changes
> you've been doing, followed by a header file change:
> 
> 	static inline void kfree(const void *p)
> 	{
> 		if (likely(p))
> 			__kfree(p);	/* __kfree(p) doesn't check for NULL p */
> 	}
> 
> along the lines that Jan considered a few posts ago, might be a winner.
> 
> But since this "likely(p)" result seems so bizarre, it seems unlikely that
> the above kfree wrapper would be a winner.
> 
I don't think it matters much really. The way I read the numbers they seem 
to indicate that the performance impact is very small in any case, and I'm 
not even entirely sure my way of trying to measure is accurate, so I don't 
know how much should be read into those numbers... 


-- 
Jesper



  reply	other threads:[~2005-03-30 19:03 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-25 22:08 [PATCH] no need to check for NULL before calling kfree() - fs/ext2/ Jesper Juhl
2005-03-25 22:29 ` linux-os
2005-03-25 22:44   ` Jesper Juhl
2005-03-26  7:50   ` Pekka Enberg
2005-03-26  8:32   ` Arjan van de Ven
2005-03-26 23:21     ` [PATCH] no need to check for NULL before calling kfree() -fs/ext2/ linux-os
2005-03-26 23:34       ` Marcin Dalecki
2005-03-27  2:00         ` Horst von Brand
2005-03-27  3:18           ` Marcin Dalecki
2005-03-27 22:12         ` linux-os
2005-03-26 23:54       ` Jesper Juhl
2005-03-27  0:05         ` Lee Revell
2005-03-27 10:55           ` Jesper Juhl
2005-03-27 14:56             ` Paul Jackson
2005-03-27 15:12               ` Jan Engelhardt
2005-03-27 17:40                 ` Dave Jones
2005-03-27 18:17                   ` Jan Engelhardt
2005-03-27 19:25                   ` Pekka Enberg
2005-03-27 22:56                   ` Jesper Juhl
2005-03-28  4:53                     ` Paul Jackson
2005-03-30 18:57                       ` Jesper Juhl [this message]
2005-03-28  1:20                   ` Horst von Brand
2005-03-28  4:10                   ` Paul Jackson
2005-03-28 12:58                   ` Geert Uytterhoeven
2005-03-29  2:52                   ` Lee Revell
2005-03-29  6:30                     ` Pekka Enberg
2005-03-29  7:06                       ` Jan Engelhardt
2005-03-29  7:24                         ` Pekka J Enberg
2005-03-30  2:44                           ` Paul Jackson
2005-03-30  6:13                             ` Pekka J Enberg
2005-03-30  6:16                               ` Paul Jackson
2005-03-30  7:15                               ` P Lavin
2005-03-30 14:20                                 ` Jesper Juhl
2005-03-30 19:10                             ` Jesper Juhl
2005-04-09  2:21                               ` Jesper Juhl
2005-03-28  4:07                 ` [PATCH] " Paul Jackson
2005-03-27  8:45       ` Arjan van de Ven
2005-03-27 12:51         ` Denis Vlasenko
2005-03-27 14:28           ` Arjan van de Ven
2005-03-27 23:13         ` [PATCH] no need to check for NULL before calling kfree()-fs/ext2/ linux-os

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0503302053100.2463@dragon.hyggekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=arjan@infradead.org \
    --cc=davej@redhat.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-os@analogic.com \
    --cc=penberg@gmail.com \
    --cc=pj@engr.sgi.com \
    --cc=rlrevell@joe-job.com \
    --cc=vda@ilport.com.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®