* [PATCH: 3 of 12] Fix TPM driver --remove unnecessary module stuff
@ 2005-05-05 19:10 Kylene Hall
0 siblings, 0 replies; 2+ messages in thread
From: Kylene Hall @ 2005-05-05 19:10 UTC (permalink / raw)
To: akpm; +Cc: jgarzik, greg, linux-kernel
Please apply these fixes to the Tpm driver. I am resubmitting the entire
patch set that was orginally sent to LKML on April 27 with the changes
that were requested fixed.
Thanks,
Kylie
On Wed, 9 Mar 2005, Jeff Garzik wrote:
> Greg KH wrote:
<snip>
> > +
> > +static int __init init_tpm(void)
> > +{
> > + return 0;
> > +}
> > +
> > +static void __exit cleanup_tpm(void)
> > +{
> > +
> > +}
> > +
> > +module_init(init_tpm);
> > +module_exit(cleanup_tpm);
>
> why? just delete these, I would say.
>
<snip>
No reason for these module definitions. This patch removes them.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
--- linux-2.6.12-rc2/drivers/chat/tpm/tpm.c 2005-04-21 17:45:30.000000000 -0500
+++ linux-2.6.12-rc2-tpmdd/drivers/char/tpm/tpm.c 2005-04-21 17:36:59.000000000 -0500
@@ -668,19 +668,6 @@ dev_num_search_complete:
EXPORT_SYMBOL_GPL(tpm_register_hardware);
-static int __init init_tpm(void)
-{
- return 0;
-}
-
-static void __exit cleanup_tpm(void)
-{
-
-}
-
-module_init(init_tpm);
-module_exit(cleanup_tpm);
-
MODULE_AUTHOR("Leendert van Doorn (leendert@watson.ibm.com)");
MODULE_DESCRIPTION("TPM Driver");
MODULE_VERSION("2.0");
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH: 3 of 12] Fix TPM driver --remove unnecessary module stuff
2005-03-10 3:51 ` Jeff Garzik
@ 2005-04-27 22:16 ` Kylene Hall
0 siblings, 0 replies; 2+ messages in thread
From: Kylene Hall @ 2005-04-27 22:16 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Greg K-H, linux-kernel
On Wed, 9 Mar 2005, Jeff Garzik wrote:
> Greg KH wrote:
<snip>
> > +
> > +static int __init init_tpm(void)
> > +{
> > + return 0;
> > +}
> > +
> > +static void __exit cleanup_tpm(void)
> > +{
> > +
> > +}
> > +
> > +module_init(init_tpm);
> > +module_exit(cleanup_tpm);
>
> why? just delete these, I would say.
>
<snip>
No reason for these module definitions. This patch removes them.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
--- linux-2.6.12-rc2/drivers/chat/tpm/tpm.c 2005-04-21 17:45:30.000000000 -0500
+++ linux-2.6.12-rc2-tpmdd/drivers/char/tpm/tpm.c 2005-04-21 17:36:59.000000000 -0500
@@ -668,19 +668,6 @@ dev_num_search_complete:
EXPORT_SYMBOL_GPL(tpm_register_hardware);
-static int __init init_tpm(void)
-{
- return 0;
-}
-
-static void __exit cleanup_tpm(void)
-{
-
-}
-
-module_init(init_tpm);
-module_exit(cleanup_tpm);
-
MODULE_AUTHOR("Leendert van Doorn (leendert@watson.ibm.com)");
MODULE_DESCRIPTION("TPM Driver");
MODULE_VERSION("2.0");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-05 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-05 19:10 [PATCH: 3 of 12] Fix TPM driver --remove unnecessary module stuff Kylene Hall
-- strict thread matches above, loose matches on Subject: below --
2005-03-10 0:42 [PATCH] Add TPM hardware enablement driver Greg KH
2005-03-10 3:51 ` Jeff Garzik
2005-04-27 22:16 ` [PATCH: 3 of 12] Fix TPM driver --remove unnecessary module stuff Kylene Hall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®