* [PATCH 7 of 12] Fix TPM driver -- use to_pci_dev
@ 2005-05-05 19:11 Kylene Hall
0 siblings, 0 replies; 2+ messages in thread
From: Kylene Hall @ 2005-05-05 19:11 UTC (permalink / raw)
To: akpm; +Cc: jgarzik, greg, linux-kernel
Please apply these fixes to the Tpm driver. I am resubmitting the entire
patch set that was orginally sent to LKML on April 27 with the changes
that were requested fixed.
Thanks,
Kylie
On Wed, 9 Mar 2005, Jeff Garzik wrote:
> Greg KH wrote:
<snip>
> > +static ssize_t show_pcrs(struct device *dev, char *buf)
> > +{
> > + u8 data[READ_PCR_RESULT_SIZE];
> > + ssize_t len;
> > + int i, j, index, num_pcrs;
> > + char *str = buf;
> > +
> > + struct tpm_chp *chip =
> > + pci_get_drvdata(container_of(dev, struct pci_dev, dev));
>
> use to_pci_dev()
<snip>
> > + ssize_t len;
> > + __be32 *native_val;
> > + int i;
> > + char *str = buf;
> > +
> > + struct tpm_chip *chip =
> > + pci_get_drvdata(container_of(dev, struct pci_dev, dev));
>
> to_pci_dev()
<snip>
> > + ssize_t len;
> > + char *str = buf;
> > +
> > + struct tpm_chip *chip =
> > + pci_get_drvdata(container_of(dev, struct pci_dev, dev));
>
> to_pci_dev()
<snip>
The following patch changes these container_of calls to 'to_pci_dev' as
suggested above.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
--- linux-2.6.12-rc2/drivers/char/tpm/tpm.c 2005-04-26 16:45:51.000000000 -0500
+++ linux-2.6.12-rc2-tpmdd/drivers/char/tpm/tpm.c 2005-04-26 16:48:12.000000000 -0500
@@ -230,7 +230,7 @@ ssize_t tpm_show_pcrs(struct device *dev
char *str = buf;
struct tpm_chip *chip =
- pci_get_drvdata(container_of(dev, struct pci_dev, dev));
+ pci_get_drvdata(to_pci_dev(dev));
if (chip == NULL)
return -ENODEV;
@@ -273,7 +273,7 @@ ssize_t tpm_show_pubek(struct device *de
char *str = buf;
struct tpm_chip *chip =
- pci_get_drvdata(container_of(dev, struct pci_dev, dev));
+ pci_get_drvdata(to_pci_dev(dev));
if (chip == NULL)
return -ENODEV;
@@ -352,7 +352,7 @@ ssize_t tpm_show_caps(struct device *dev
char *str = buf;
struct tpm_chip *chip =
- pci_get_drvdata(container_of(dev, struct pci_dev, dev));
+ pci_get_drvdata(to_pci_dev(dev));
if (chip == NULL)
return -ENODEV;
\
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 7 of 12] Fix TPM driver -- use to_pci_dev
2005-03-10 3:51 ` Jeff Garzik
@ 2005-04-27 22:18 ` Kylene Hall
0 siblings, 0 replies; 2+ messages in thread
From: Kylene Hall @ 2005-04-27 22:18 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Greg K-H, linux-kernel
On Wed, 9 Mar 2005, Jeff Garzik wrote:
> Greg KH wrote:
<snip>
> > +static ssize_t show_pcrs(struct device *dev, char *buf)
> > +{
> > + u8 data[READ_PCR_RESULT_SIZE];
> > + ssize_t len;
> > + int i, j, index, num_pcrs;
> > + char *str = buf;
> > +
> > + struct tpm_chp *chip =
> > + pci_get_drvdata(container_of(dev, struct pci_dev, dev));
>
> use to_pci_dev()
<snip>
> > + ssize_t len;
> > + __be32 *native_val;
> > + int i;
> > + char *str = buf;
> > +
> > + struct tpm_chip *chip =
> > + pci_get_drvdata(container_of(dev, struct pci_dev, dev));
>
> to_pci_dev()
<snip>
> > + ssize_t len;
> > + char *str = buf;
> > +
> > + struct tpm_chip *chip =
> > + pci_get_drvdata(container_of(dev, struct pci_dev, dev));
>
> to_pci_dev()
<snip>
The following patch changes these container_of calls to 'to_pci_dev' as
suggested above.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
--- linux-2.6.12-rc2/drivers/char/tpm/tpm.c 2005-04-26 16:45:51.000000000 -0500
+++ linux-2.6.12-rc2-tpmdd/drivers/char/tpm/tpm.c 2005-04-26 16:48:12.000000000 -0500
@@ -230,7 +230,7 @@ ssize_t tpm_show_pcrs(struct device *dev
char *str = buf;
struct tpm_chip *chip =
- pci_get_drvdata(container_of(dev, struct pci_dev, dev));
+ pci_get_drvdata(to_pci_dev(dev));
if (chip == NULL)
return -ENODEV;
@@ -273,7 +273,7 @@ ssize_t tpm_show_pubek(struct device *de
char *str = buf;
struct tpm_chip *chip =
- pci_get_drvdata(container_of(dev, struct pci_dev, dev));
+ pci_get_drvdata(to_pci_dev(dev));
if (chip == NULL)
return -ENODEV;
@@ -352,7 +352,7 @@ ssize_t tpm_show_caps(struct device *dev
char *str = buf;
struct tpm_chip *chip =
- pci_get_drvdata(container_of(dev, struct pci_dev, dev));
+ pci_get_drvdata(to_pci_dev(dev));
if (chip == NULL)
return -ENODEV;
\
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-05 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-05 19:11 [PATCH 7 of 12] Fix TPM driver -- use to_pci_dev Kylene Hall
-- strict thread matches above, loose matches on Subject: below --
2005-03-10 0:42 [PATCH] Add TPM hardware enablement driver Greg KH
2005-03-10 3:51 ` Jeff Garzik
2005-04-27 22:18 ` [PATCH 7 of 12] Fix TPM driver -- use to_pci_dev Kylene Hall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®