From: Christoph Lameter <christoph@lameter.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
Date: Tue, 17 May 2005 19:52:38 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.62.0505171941340.21153@graphe.net> (raw)
In-Reply-To: <20050517190343.2e57fdd7.akpm@osdl.org>
On Tue, 17 May 2005, Andrew Morton wrote:
> Christoph Lameter <christoph@graphe.net> wrote:
> >
> > NUMA awareness for the e1000 driver. Allocate transmit and receive buffers
> > on the node of the device.
>
> Hast thou any benchmarking results?
Yes, your honor. Just a second .... The patch has been around for a long
time.
No benchmarks results in my email archive. Would need to talk to some
folks tomorrow and maybe we would have to run some new
benchmarks.
> > - txdr->buffer_info = vmalloc(size);
> > + txdr->buffer_info = kmalloc_node(size, GFP_KERNEL, node);
>
> How come that this is safe to do
Because physically contiguous memory is usually better than virtually
contiguous memory? Any reason that physically contiguous memory will
break the driver?
next prev parent reply other threads:[~2005-05-18 2:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 1:56 Christoph Lameter
2005-05-18 2:03 ` Andrew Morton
2005-05-18 2:52 ` Christoph Lameter [this message]
[not found] ` <20050517.195703.104034854.davem@davemloft.net>
2005-05-18 4:27 ` Christoph Lameter
2005-05-18 4:58 ` Andrew Morton
2005-05-18 15:55 ` Ganesh Venkatesan
2005-05-18 20:42 ` Andrew Morton
2005-05-27 21:52 ` [PATCH] e1000: NUMA aware allocation of descriptors V2 Christoph Lameter
2005-05-27 23:25 ` Andrew Morton
2005-05-18 13:19 ` [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0505171941340.21153@graphe.net \
--to=christoph@lameter.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®