From: Christoph Lameter <christoph@lameter.com>
To: Nigel Cunningham <ncunningham@cyclades.com>
Cc: Pavel Machek <pavel@ucw.cz>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] Task notifier: Implement todo list in task_struct
Date: Mon, 8 Aug 2005 19:01:37 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.62.0508081858040.32489@graphe.net> (raw)
In-Reply-To: <1123551167.9451.5.camel@localhost>
On Tue, 9 Aug 2005, Nigel Cunningham wrote:
> Just to let you know that I have it working with Suspend2. One thing I
> am concerned about is that we still need a way of determining whether a
> process has been signalled but not yet frozen. At the moment you just
> check p->todo, but if/when other functionality begins to use the todo
> list, this will be unreliable.
>
No it wont. A process that has notifications to process should do that
before being put into the freezer. Only after the notification list is
empty will the process be notified and as long as the notification is
pending no second notification should happen.
> I'm happy to supply the patches I'm using if you want to compare. (I
> retained the other freezer improvements, so it wouldn't just be bug
> fixes against your patches).
I am not sure how to sort that out. I guess post the current patches that
you got and then we see how to continue from there.
next prev parent reply other threads:[~2005-08-09 2:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200507260340.j6Q3eoGh029135@shell0.pdx.osdl.net>
2005-07-28 3:30 ` Alternative to TIF_FREEZE -> a notifier in the task_struct? Christoph Lameter
2005-07-28 7:41 ` Pavel Machek
2005-07-28 15:05 ` Christoph Lameter
2005-07-28 19:34 ` Pavel Machek
2005-07-28 19:49 ` Christoph Lameter
2005-07-28 19:54 ` [PATCH 1/4] Task notifier: Allow the removal of a notifier from the notifier handler Christoph Lameter
2005-07-28 19:55 ` [PATCH 2/4] Task notifier: Implement todo list in task_struct Christoph Lameter
2005-07-28 19:57 ` [PATCH 3/4] Task notifier: Make suspend code SMP safe using the todo list in the task struct Christoph Lameter
2005-07-28 19:59 ` [PATCH 4/4] Task notifier: s/try_to_freeze/try_todo_list/ in some drivers [optional] Christoph Lameter
2005-07-28 21:27 ` [PATCH 2/4] Task notifier: Implement todo list in task_struct Pavel Machek
2005-07-28 21:32 ` Pavel Machek
2005-07-28 21:57 ` Christoph Lameter
2005-07-28 22:12 ` Pavel Machek
2005-07-28 23:02 ` Christoph Lameter
2005-07-28 23:27 ` Andrew Morton
2005-07-29 0:19 ` Christoph Lameter
2005-08-09 1:32 ` Nigel Cunningham
2005-08-09 2:01 ` Christoph Lameter [this message]
2005-08-09 3:51 ` Nigel Cunningham
2005-08-09 4:21 ` Nigel Cunningham
2005-08-09 17:05 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0508081858040.32489@graphe.net \
--to=christoph@lameter.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@cyclades.com \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®