From: Nicolas Pitre <nico@cam.org>
To: Andrew Morton <akpm@osdl.org>, Herbert Xu <herbert@gondor.apana.org.au>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/5] crypto/sha1.c: avoid shifting count left and right
Date: Mon, 24 Oct 2005 13:57:06 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0510241356270.5288@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0510241347081.5288@localhost.localdomain>
This patch avoids shifting the count left and right needlessly for each
call to sha1_update(). It instead can be done only once at the end in
sha1_final().
Keeping the previous test example (sha1_update() successively called with
len=64), a 1.3% performance increase can be observed on i386, or 0.2% on
ARM. The generated code is also smaller on ARM.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Index: linux-2.6/crypto/sha1.c
===================================================================
--- linux-2.6.orig/crypto/sha1.c
+++ linux-2.6/crypto/sha1.c
@@ -51,8 +51,8 @@
unsigned int partial, done;
u32 temp[SHA_WORKSPACE_WORDS];
- partial = (sctx->count >> 3) & 0x3f;
- sctx->count += len << 3;
+ partial = sctx->count & 0x3f;
+ sctx->count += len;
done = 0;
if ((partial + len) > 63) {
@@ -80,7 +80,7 @@
u8 bits[8] = { 0, };
static const u8 padding[64] = { 0x80, };
- t = sctx->count;
+ t = sctx->count << 3;
bits[7] = 0xff & t; t>>=8;
bits[6] = 0xff & t; t>>=8;
bits[5] = 0xff & t; t>>=8;
@@ -91,7 +91,7 @@
bits[0] = 0xff & t;
/* Pad out to 56 mod 64 */
- index = (sctx->count >> 3) & 0x3f;
+ index = sctx->count & 0x3f;
padlen = (index < 56) ? (56 - index) : ((64+56) - index);
sha1_update(sctx, padding, padlen);
next prev parent reply other threads:[~2005-10-24 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 17:54 [PATCH 0/5] crypto/sha1.c: code cleanup Nicolas Pitre
2005-10-24 17:56 ` [PATCH 1/5] crypto/sha1.c: avoid useless memcpy() Nicolas Pitre
2005-10-24 17:57 ` Nicolas Pitre [this message]
2005-11-13 0:29 ` [PATCH 2/5] crypto/sha1.c: avoid shifting count left and right Herbert Xu
2005-10-24 17:57 ` [PATCH 3/5] crypto/sha1.c: move related code together Nicolas Pitre
2005-10-24 18:03 ` Nicolas Pitre
2005-10-24 18:03 ` [PATCH 5/5] crypto/sha1.c: final cleanup Nicolas Pitre
2005-10-24 18:05 ` [PATCH 4/5] crypto/sha1.c: avoid successively shifting a long long Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0510241356270.5288@localhost.localdomain \
--to=nico@cam.org \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®