From: Nicolas Pitre <nico@cam.org>
To: Andrew Morton <akpm@osdl.org>, Herbert Xu <herbert@gondor.apana.org.au>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/5] crypto/sha1.c: final cleanup
Date: Mon, 24 Oct 2005 14:03:59 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0510241403310.5288@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0510241347081.5288@localhost.localdomain>
We don't need j nor t2. Simplify the code a bit by reusing t and
incrementing the 'out' pointer (it is a bit easier on the compiler
as it reduce register pressure).
Signed-off-by: Nicolas Pitre <nico@cam.org>
Index: linux-2.6/crypto/sha1.c
===================================================================
--- linux-2.6.orig/crypto/sha1.c
+++ linux-2.6/crypto/sha1.c
@@ -76,7 +76,7 @@
{
struct sha1_ctx *sctx = ctx;
u64 count = sctx->count;
- u32 i, j, index, padlen, t;
+ u32 i, index, padlen, t;
u8 bits[8];
static const u8 padding[64] = { 0x80, };
@@ -99,12 +99,13 @@
sha1_update(sctx, bits, sizeof bits);
/* Store state in digest */
- for (i = j = 0; i < 5; i++, j += 4) {
- u32 t2 = sctx->state[i];
- out[j+3] = t2 & 0xff; t2>>=8;
- out[j+2] = t2 & 0xff; t2>>=8;
- out[j+1] = t2 & 0xff; t2>>=8;
- out[j ] = t2 & 0xff;
+ for (i = 0; i < 5; i++) {
+ t = sctx->state[i];
+ out[3] = t & 0xff; t>>=8;
+ out[2] = t & 0xff; t>>=8;
+ out[1] = t & 0xff; t>>=8;
+ out[0] = t & 0xff;
+ out += 4;
}
/* Wipe context */
next prev parent reply other threads:[~2005-10-24 18:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 17:54 [PATCH 0/5] crypto/sha1.c: code cleanup Nicolas Pitre
2005-10-24 17:56 ` [PATCH 1/5] crypto/sha1.c: avoid useless memcpy() Nicolas Pitre
2005-10-24 17:57 ` [PATCH 2/5] crypto/sha1.c: avoid shifting count left and right Nicolas Pitre
2005-11-13 0:29 ` Herbert Xu
2005-10-24 17:57 ` [PATCH 3/5] crypto/sha1.c: move related code together Nicolas Pitre
2005-10-24 18:03 ` Nicolas Pitre
2005-10-24 18:03 ` Nicolas Pitre [this message]
2005-10-24 18:05 ` [PATCH 4/5] crypto/sha1.c: avoid successively shifting a long long Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0510241403310.5288@localhost.localdomain \
--to=nico@cam.org \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®