From: James Morris <jmorris@namei.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
David Quigley <dpquigl@tycho.nsa.gov>
Subject: Re: [PATCH 1/3] SELinux: Extend task_kill hook to handle signals sent by AIO completion
Date: Thu, 29 Jun 2006 11:43:45 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606291142220.24029@d.namei> (raw)
In-Reply-To: <1151595104.6999.67.camel@moss-spartans.epoch.ncsc.mil>
On Thu, 29 Jun 2006, Stephen Smalley wrote:
> On Wed, 2006-06-28 at 17:16 -0700, Chris Wright wrote:
> > > + void (*task_getsecid) (struct task_struct * p, u32 * secid);
> >
> > Why not just:
> > u32 (*task_getsecid) (struct task_struct *p);
>
> That's fine, although we should then change the SELinux exports as well
> to be consistent (and convert them all to secid rather than sid or
> ctxid, and eliminate duplication there that has crept in). That can be
> done by later patch.
My preference is to leave it as-is, because these interfaces generally
return only error values. IMHO, it's always much clearer that way in any
case, for APIs like this.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2006-06-29 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 23:45 James Morris
2006-06-28 23:46 ` [PATCH 2/3] SELinux: Add security hook call to kill_proc_info_as_uid James Morris
2006-06-28 23:49 ` [PATCH 3/3] SELinux: Update USB code with new kill_proc_info_as_uid James Morris
2006-06-29 23:57 ` Greg KH
2006-06-29 0:16 ` [PATCH 1/3] SELinux: Extend task_kill hook to handle signals sent by AIO completion Chris Wright
2006-06-29 0:37 ` James Morris
2006-06-29 0:52 ` Chris Wright
2006-06-29 0:55 ` Andrew Morton
2006-06-29 1:45 ` James Morris
2006-06-29 15:31 ` Stephen Smalley
2006-06-29 15:43 ` James Morris [this message]
2006-06-29 15:54 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606291142220.24029@d.namei \
--to=jmorris@namei.org \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=dpquigl@tycho.nsa.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®