From: Linus Torvalds <torvalds@osdl.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [GIT] Linux client patches against Linux 2.6.18
Date: Sat, 23 Sep 2006 17:06:22 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0609231700210.4388@g5.osdl.org> (raw)
In-Reply-To: <1158982165.5493.12.camel@lade.trondhjem.org>
On Fri, 22 Sep 2006, Trond Myklebust wrote:
>
> git pull git://git.linux-nfs.org/pub/linux/nfs-2.6.git
I'm not entirely happy with this.
Why were the generic VFS layer patches wrapped up in this big thing,
instead of being sent separately with the proper people looking at them?
I'm not seeing a sign-off or ack for the dentry stuff from Al, for
example. Was it passed by him? You moved the dentry rehash function inside
the dcache_lock, and if that was a bug-fix, it should have been marked as
so and done separately etc.
In other words, this was _not_ the right way to merge these things. I'm a
bit grumpy.
Linus
next parent reply other threads:[~2006-09-24 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1158982165.5493.12.camel@lade.trondhjem.org>
2006-09-24 0:06 ` Linus Torvalds [this message]
2006-09-24 6:37 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0609231700210.4388@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®