mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [GIT] Linux client patches against Linux 2.6.18
Date: Sun, 24 Sep 2006 02:37:55 -0400	[thread overview]
Message-ID: <1159079875.5633.74.camel@lade.trondhjem.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0609231700210.4388@g5.osdl.org>

On Sat, 2006-09-23 at 17:06 -0700, Linus Torvalds wrote:

> I'm not seeing a sign-off or ack for the dentry stuff from Al, for 
> example. Was it passed by him? You moved the dentry rehash function inside 
> the dcache_lock, and if that was a bug-fix, it should have been marked as 
> so and done separately etc.

The only function that was moved inside the spinlock was d_hash(), but
that is a fairly trivial change (d_revalidate already does the same).
Otherwise, the only effect of the changes was to create unlocked
versions of d_rehash() for reuse in the new d_materialise_dentry().

In any case, all of those patches have been presented by David on the
fs-devel and lkml lists several times. The last time would be on 27th
July:

 http://marc.theaimsgroup.com/?l=linux-kernel&m=115403487316197&w=2

Al has in addition been Cced on much of the correspondence between David
and myself during the preparation for merging (although that would be
almost half a year ago now).
Finally, Christoph was also pressed into duty as an extra reviewer.

So yes, afaik all the relevant people have been kept informed, even if
they were not labelled as having been Cced in the changelog.

So I apologize for not having sent this as a separate patch, but as I
said above, it was a trivial change as far as the rehash is concerned,
and the only user of the new function is NFS.

Cheers,
  Trond


      reply	other threads:[~2006-09-24  6:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1158982165.5493.12.camel@lade.trondhjem.org>
2006-09-24  0:06 ` Linus Torvalds
2006-09-24  6:37   ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159079875.5633.74.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®