* [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong
@ 2006-10-10 6:27 Robert P. J. Day
2006-10-10 9:15 ` Alexey Dobriyan
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2006-10-10 6:27 UTC (permalink / raw)
To: Linux kernel mailing list; +Cc: trivial
I'm *guessing* that "_DEBUG_DRIVER_" should really be "DEBUG_DRIVER"
here, since there is no other occurrence of the former anywhere in the
source tree.
Signed-off-by: Robert P. J. Day <rpjday@mindspting.com>
---
drivers/net/ixgb/ixgb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
index 50ffe90..b2dd9b0 100644
--- a/drivers/net/ixgb/ixgb.h
+++ b/drivers/net/ixgb/ixgb.h
@@ -77,7 +77,7 @@ #include "ixgb_hw.h"
#include "ixgb_ee.h"
#include "ixgb_ids.h"
-#ifdef _DEBUG_DRIVER_
+#ifdef DEBUG_DRIVER
#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
#else
#define IXGB_DBG(args...)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong
2006-10-10 6:27 [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong Robert P. J. Day
@ 2006-10-10 9:15 ` Alexey Dobriyan
2006-10-10 9:28 ` Robert P. J. Day
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2006-10-10 9:15 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-kernel, trivial
On Tue, Oct 10, 2006 at 02:27:34AM -0400, Robert P. J. Day wrote:
> I'm *guessing* that "_DEBUG_DRIVER_" should really be "DEBUG_DRIVER"
> here, since there is no other occurrence of the former anywhere in the
> source tree.
Since it's debugging guard, underscored or not... doesn't matter. Convert to
pr_debug or dev_dbg of you want to deal with it.
> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
> @@ -77,7 +77,7 @@ #include "ixgb_hw.h"
> #include "ixgb_ee.h"
> #include "ixgb_ids.h"
>
> -#ifdef _DEBUG_DRIVER_
> +#ifdef DEBUG_DRIVER
> #define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> #else
> #define IXGB_DBG(args...)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong
2006-10-10 9:15 ` Alexey Dobriyan
@ 2006-10-10 9:28 ` Robert P. J. Day
2006-10-10 10:01 ` Arjan van de Ven
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2006-10-10 9:28 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, trivial
On Tue, 10 Oct 2006, Alexey Dobriyan wrote:
> On Tue, Oct 10, 2006 at 02:27:34AM -0400, Robert P. J. Day wrote:
> > I'm *guessing* that "_DEBUG_DRIVER_" should really be
> > "DEBUG_DRIVER" here, since there is no other occurrence of the
> > former anywhere in the source tree.
>
> Since it's debugging guard, underscored or not... doesn't matter.
> Convert to pr_debug or dev_dbg of you want to deal with it.
>
> > --- a/drivers/net/ixgb/ixgb.h
> > +++ b/drivers/net/ixgb/ixgb.h
> > @@ -77,7 +77,7 @@ #include "ixgb_hw.h"
> > #include "ixgb_ee.h"
> > #include "ixgb_ids.h"
> >
> > -#ifdef _DEBUG_DRIVER_
> > +#ifdef DEBUG_DRIVER
> > #define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> > #else
> > #define IXGB_DBG(args...)
but what you're suggesting is not equivalent. i submitted that patch
to fix what *seems* to be an obvious, innocuous typo, to bring that
one header file into sync with the rest of the source tree, nothing
more.
if all debugging should now use either of pr_debug() or dev_dbg(),
that's fine but i notice that both of those macros will be defined
only if "DEBUG" is defined, not "DEBUG_DRIVER". so making the change
you suggest would *not* be a trivial change.
what's the current standard for debugging directives in the kernel?
rday
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong
2006-10-10 9:28 ` Robert P. J. Day
@ 2006-10-10 10:01 ` Arjan van de Ven
0 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2006-10-10 10:01 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Alexey Dobriyan, linux-kernel, trivial
On Tue, 2006-10-10 at 05:28 -0400, Robert P. J. Day wrote:
> On Tue, 10 Oct 2006, Alexey Dobriyan wrote:
>
> > On Tue, Oct 10, 2006 at 02:27:34AM -0400, Robert P. J. Day wrote:
> > > I'm *guessing* that "_DEBUG_DRIVER_" should really be
> > > "DEBUG_DRIVER" here, since there is no other occurrence of the
> > > former anywhere in the source tree.
> >
> > Since it's debugging guard, underscored or not... doesn't matter.
> > Convert to pr_debug or dev_dbg of you want to deal with it.
> >
> > > --- a/drivers/net/ixgb/ixgb.h
> > > +++ b/drivers/net/ixgb/ixgb.h
> > > @@ -77,7 +77,7 @@ #include "ixgb_hw.h"
> > > #include "ixgb_ee.h"
> > > #include "ixgb_ids.h"
> > >
> > > -#ifdef _DEBUG_DRIVER_
> > > +#ifdef DEBUG_DRIVER
> > > #define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> > > #else
> > > #define IXGB_DBG(args...)
>
> but what you're suggesting is not equivalent. i submitted that patch
> to fix what *seems* to be an obvious, innocuous typo, to bring that
> one header file into sync with the rest of the source tree, nothing
> more.
>
> if all debugging should now use either of pr_debug() or dev_dbg(),
> that's fine but i notice that both of those macros will be defined
> only if "DEBUG" is defined, not "DEBUG_DRIVER". so making the change
> you suggest would *not* be a trivial change.
>
> what's the current standard for debugging directives in the kernel?
to use pr_debug or dev_dbg.
Yes it'll mean a slight change for this driver, but just do it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-10-10 10:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-10 6:27 [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong Robert P. J. Day
2006-10-10 9:15 ` Alexey Dobriyan
2006-10-10 9:28 ` Robert P. J. Day
2006-10-10 10:01 ` Arjan van de Ven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®