From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: why "probe_kernel_address()", not "probe_user_address()"?
Date: Sat, 28 Oct 2006 11:56:24 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610281153180.2091@localhost.localdomain> (raw)
it seems odd that the purpose of the "probe_kernel_address()" macro
is, in fact, to probe a *user* address (from linux/uaccess.h):
#define probe_kernel_address(addr, retval) \
({ \
long ret; \
\
inc_preempt_count(); \
ret = __get_user(retval, addr); \
dec_preempt_count(); \
ret; \
})
given that that routine is referenced only 5 places in the entire
source tree, wouldn't it be more meaningful to use a more appropriate
name?
pedantically yours,
rday
next reply other threads:[~2006-10-28 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 15:56 Robert P. J. Day [this message]
2006-10-28 16:29 ` Andrew Morton
2006-10-28 16:52 ` Robert P. J. Day
2006-10-28 17:02 ` Robert P. J. Day
2006-10-28 20:30 ` Luca Tettamanti
2006-10-28 21:01 ` Robert P. J. Day
2006-10-29 15:49 ` Luca Tettamanti
2006-10-29 13:02 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610281153180.2091@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®