From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: why "probe_kernel_address()", not "probe_user_address()"?
Date: Sat, 28 Oct 2006 17:01:31 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610281659250.4741@localhost.localdomain> (raw)
In-Reply-To: <20061028203014.GA7183@dreamland.darkstar.lan>
On Sat, 28 Oct 2006, Luca Tettamanti wrote:
> I agree that it may be confusing. The whole point in using
> __get_user() is that it ensures that the source address is valid.
>
> When handle_BUG() is called the kernel is no more in a "sane" state,
> blindly using the content of the registers may lead to a page fault
> in kernel mode. So the code extract filename and line of the BUG
> checking that the line number is indeed readable, the address of the
> string (file name) is readable and it points to a readable memory
> location.
>
> probe_kernel_address wrapper is used to "hide" the fact that we are
> re-using the infrastructure provided by a function with a confusing
> name ;) The cast to __user is needed to keep sparse quiet.
... more response snipped ...
ok, i'm going to defer to people who are clearly much smarter about
this than me, and i'll go back and read that entire response more
carefully until i understand it. thanks for explaining it.
rday
next prev parent reply other threads:[~2006-10-28 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 15:56 Robert P. J. Day
2006-10-28 16:29 ` Andrew Morton
2006-10-28 16:52 ` Robert P. J. Day
2006-10-28 17:02 ` Robert P. J. Day
2006-10-28 20:30 ` Luca Tettamanti
2006-10-28 21:01 ` Robert P. J. Day [this message]
2006-10-29 15:49 ` Luca Tettamanti
2006-10-29 13:02 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610281659250.4741@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®