From: Hugh Dickins <hugh@veritas.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, patches@x86-64.org
Subject: Re: [PATCH] x86-64: adjust pmd_bad()
Date: Wed, 15 Nov 2006 17:01:54 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0611151658520.24160@blonde.wat.veritas.com> (raw)
In-Reply-To: <455B3AF2.76E4.0078.0@novell.com>
On Wed, 15 Nov 2006, Jan Beulich wrote:
> Make pmd_bad() symmetrical to pgd_bad() and pud_bad(). At once,
> simplify them all.
Symmetrical and simpler, yes, but you're weakening the pmd_bad() test:
no longer requires that all those _KERNPG_TABLE bits be set. Wouldn't
it be better to go the other way and strengthen pgd_bad, pud_bad?
Hugh
next prev parent reply other threads:[~2006-11-15 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 15:06 Jan Beulich
2006-11-15 16:31 ` [patches] " Andi Kleen
2006-11-15 17:01 ` Hugh Dickins [this message]
2006-11-15 17:12 ` Jan Beulich
2006-11-15 17:23 ` [patches] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611151658520.24160@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=ak@suse.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®