From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: any value to "struct configfs_attribute" anymore?
Date: Sun, 3 Dec 2006 05:43:21 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612030534070.2710@localhost.localdomain> (raw)
as a followup to my previous patch submission, is there any value to
the definition of "struct configfs_attribute" in configfs.h anymore,
given a similar structure in sysfs.h?
configfs.h:
-----------
struct configfs_attribute {
const char *ca_name;
struct module *ca_owner;
mode_t ca_mode;
};
sysfs.h:
--------
struct attribute {
const char * name;
struct module * owner;
mode_t mode;
};
if these two structs are *necessarily* identical, then it would make
sense to remove the few remaining uses of the former and replace them
with references to the latter, no? there are only a few files that
appear to still make reference to the former:
fs/configfs/inode.c
fs/ocfs2/cluster/heartbeat.c
fs/ocfs2/cluster/nodemanager.c
fs/dlm/config.c
so standardizing on the latter would be fairly easy. or is there a
reason why those two structures still have to be treated
independently?
rday
reply other threads:[~2006-12-03 10:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612030534070.2710@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®