mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* any value to "struct configfs_attribute" anymore?
@ 2006-12-03 10:43 Robert P. J. Day
  0 siblings, 0 replies; only message in thread
From: Robert P. J. Day @ 2006-12-03 10:43 UTC (permalink / raw)
  To: Linux kernel mailing list


  as a followup to my previous patch submission, is there any value to
the definition of "struct configfs_attribute" in configfs.h anymore,
given a similar structure in sysfs.h?

configfs.h:
-----------

struct configfs_attribute {
        const char              *ca_name;
        struct module           *ca_owner;
        mode_t                  ca_mode;
};

sysfs.h:
--------

struct attribute {
        const char              * name;
        struct module           * owner;
        mode_t                  mode;
};

  if these two structs are *necessarily* identical, then it would make
sense to remove the few remaining uses of the former and replace them
with references to the latter, no?  there are only a few files that
appear to still make reference to the former:

fs/configfs/inode.c
fs/ocfs2/cluster/heartbeat.c
fs/ocfs2/cluster/nodemanager.c
fs/dlm/config.c

so standardizing on the latter would be fairly easy.  or is there a
reason why those two structures still have to be treated
independently?

rday

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-03 10:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-03 10:43 any value to "struct configfs_attribute" anymore? Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®