From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: why are some of my patches being credited to other "authors"?
Date: Sat, 9 Dec 2006 05:22:32 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612090515480.12992@localhost.localdomain> (raw)
perhaps i'm just being clueless about the authorship protocol here,
but i'm a bit hacked off by noticing that at least one submitted patch
of mine was apparently re-submitted (albeit slightly modified) a few
days later by another poster and applied under that poster's name.
on sun, dec 3, i submitted to the list:
http://marc.theaimsgroup.com/?l=linux-kernel&m=116516635728664&w=2
and yet, just by accident this morning, i see the log for that file
ipc/sem.c contains:
======================================================
commit 4668edc334ee90cf50c382c3e423cfc510b5a126
Author: Burman Yan <yan_952@hotmail.com>
Date: Wed Dec 6 20:38:51 2006 -0800
[PATCH] kernel core: replace kmalloc+memset with kzalloc
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
diff --git a/ipc/sem.c b/ipc/sem.c
index 21b3289..d3e12ef 100644
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -1070,14 +1070,13 @@ static struct sem_undo *find_undo(struct
ipc_rcu_getref(sma);
sem_unlock(sma);
- new = (struct sem_undo *) kmalloc(sizeof(struct sem_undo) + sizeof(short)*nsems, GFP_KERNEL);
+ new = kzalloc(sizeof(struct sem_undo) + sizeof(short)*nsems, GFP_KERNEL);
if (!new) {
ipc_lock_by_ptr(&sma->sem_perm);
ipc_rcu_putref(sma);
sem_unlock(sma);
return ERR_PTR(-ENOMEM);
}
- memset(new, 0, sizeof(struct sem_undo) + sizeof(short)*nsems);
new->semadj = (short *) &new[1];
new->semid = semid;
======================================================
admittedly, mr. yan's patch is technically cleaner since it removes
the superfluous cast applied to kzalloc(). however, i very
*deliberately* left that cast in, and i explained why a couple days
later here in another context:
http://marc.theaimsgroup.com/?l=linux-kernel&m=116553652920469&w=2
quite simply, as per the guidelines given for creating and
submitting kernel patches, i'm trying to keep each submission
well-defined, as i was going to follow up the above with another
submission to remove *all* superfluous casts in one fell swoop. but
it's not just a matter of proper patch attribution.
i've submitted a number of patches recently and, every time i do a
"git pull", i check the log to see if any of them have been applied so
i can delete them from my personal "submitted but not applied"
directory. if they've been applied by another author, then naturally
i'll never notice and i'll keep wondering about the delay.
so what's the protocol here? are more senior kernel developers
allowed to poach on my patch submissions, tidy them up slightly, then
drop any attribution to me? enquiring minds *definitely* want this
cleared up.
rday
p.s. it's possible that this is all just a wild coincidence, of
course. stranger things have happened.
next reply other threads:[~2006-12-09 10:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 10:22 Robert P. J. Day [this message]
2006-12-09 11:29 ` Benjamin Herrenschmidt
2006-12-09 12:05 ` Robert P. J. Day
2006-12-09 12:39 ` Tim Schmielau
2006-12-09 13:16 ` Robert P. J. Day
2006-12-09 13:55 ` Jesper Juhl
2006-12-09 11:34 ` Jeff Garzik
2006-12-09 12:11 ` Robert P. J. Day
2006-12-09 21:40 ` Stefan Richter
2006-12-10 5:09 ` Paul Mundt
2006-12-10 19:19 ` Adrian Bunk
2006-12-09 13:48 ` Pekka Enberg
2006-12-10 7:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612090515480.12992@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®