From: Linus Torvalds <torvalds@linux-foundation.org>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Avi Kivity <avi@argo.co.il>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Zach Brown <zach.brown@oracle.com>,
Benjamin LaHaise <bcrl@kvack.org>
Subject: Re: [patch 13/13] signal/timer/event fds v9 - KAIO eventfd support example ...
Date: Sun, 1 Apr 2007 10:23:00 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704011020000.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704011000470.26331@alien.or.mcafeemobile.com>
On Sun, 1 Apr 2007, Davide Libenzi wrote:
>
> > [also, minor nit: sys_eventfd() can legitimately return 0, but you're banning
> > its use in aio. userspace could easily dup() and close(), but...]
>
> Noone said that binary compatibility comes free ;)
> I'm truly open to other ways of integration, but I thought that binary
> compatibility is the key here.
I would suggest taking "aio_reserved3" and turning it into
__u32 aio_flags;
__u32 aio_resfd;
if so. And then some bit in the "flags" field has to be set (say,
"IOCB_FLAG_RESFB") to enable this codepath, instead of expecting that
aio_resfd == 0 is special.
It's generally always a good thing to have a "flags" field anyway, exactly
because it allows for future expansion.
Linus
next prev parent reply other threads:[~2007-04-01 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 20:09 Davide Libenzi
2007-04-01 15:06 ` Avi Kivity
2007-04-01 17:07 ` Davide Libenzi
2007-04-01 17:23 ` Linus Torvalds [this message]
2007-04-01 17:31 ` Davide Libenzi
2007-04-01 18:42 ` Avi Kivity
2007-04-01 18:49 ` Davide Libenzi
2007-04-01 20:11 ` Avi Kivity
2007-04-01 20:20 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704011020000.6730@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=avi@argo.co.il \
--cc=bcrl@kvack.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suparna@in.ibm.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®