mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Krzysztof Halasa <khc@pm.waw.pl>, Adrian Bunk <bunk@stusta.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: any value to "NORET_TYPE" macro?
Date: Thu, 24 May 2007 12:43:07 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0705241239560.10926@localhost.localdomain> (raw)
In-Reply-To: <a781481a0705230646x9a0255ak4254d05ba5442cad@mail.gmail.com>

On Wed, 23 May 2007, Satyam Sharma wrote:

> Actually there's another thing :-) The __attribute__((xxx)) must go
> with the function _declarations_ (and not the
> implementations/definitions).

that's not true, AFAICT.  the pattern seems to be that, in the case of
declarations, attributes go at the end, as in:

arch/sparc/boot/btfixupprep.c:void fatal(void) __attribute__((noreturn));

while in actual definitions, they typically go after the return type,
as in arch/arm/kernel/traps.c:

void __attribute__((noreturn)) __bug(const char *file, int line)
{
        printk(KERN_CRIT"kernel BUG at %s:%d!\n", file, line);
        *(int *)0 = 0;

        /* Avoid "noreturn function does return" */
        for (;;);
}

  is that the standard that most people use?  if it is, i can use that
standard for the cleanup.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

  parent reply	other threads:[~2007-05-24 16:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 13:09 Robert P. J. Day
2007-05-22 13:53 ` John Anthony Kazos Jr.
2007-05-22 14:01   ` Robert P. J. Day
2007-05-22 14:09     ` Satyam Sharma
2007-05-22 14:16       ` Satyam Sharma
2007-05-22 14:43         ` Krzysztof Halasa
2007-05-22 15:24           ` Satyam Sharma
2007-05-22 19:45           ` Geert Uytterhoeven
2007-05-22 14:47       ` Robert P. J. Day
2007-05-22 13:59 ` Adrian Bunk
2007-05-22 14:04   ` Robert P. J. Day
2007-05-22 16:19     ` Adrian Bunk
2007-05-22 17:04       ` Satyam Sharma
2007-05-22 17:18         ` Robert P. J. Day
2007-05-22 19:25       ` Krzysztof Halasa
2007-05-22 20:17         ` Robert P. J. Day
2007-05-22 20:39           ` Krzysztof Halasa
2007-05-23  8:37             ` Satyam Sharma
2007-05-23 13:09               ` Robert P. J. Day
2007-05-23 13:46                 ` Satyam Sharma
2007-05-24 13:10                   ` Krzysztof Halasa
2007-05-24 13:25                     ` Robert P. J. Day
2007-05-24 17:12                     ` Satyam Sharma
2007-05-24 16:43                   ` Robert P. J. Day [this message]
2007-05-24 18:53                     ` Satyam Sharma
2007-05-25 17:33                       ` Robert P. J. Day
2007-05-25 17:36                       ` Robert P. J. Day
2007-05-25 19:25                         ` Satyam Sharma
2007-05-25 19:40                           ` Robert P. J. Day
2007-05-25 21:46                             ` Adrian Bunk
2007-05-26 21:56                     ` Krzysztof Halasa
2007-05-22 22:41           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0705241239560.10926@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=bunk@stusta.de \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satyam.sharma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®