mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Krzysztof Halasa" <khc@pm.waw.pl>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
	"Adrian Bunk" <bunk@stusta.de>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: any value to "NORET_TYPE" macro?
Date: Thu, 24 May 2007 22:42:27 +0530	[thread overview]
Message-ID: <a781481a0705241012j513957d8vbc993cb395c31158@mail.gmail.com> (raw)
In-Reply-To: <m33b1mz7sz.fsf@maximus.localdomain>

On 5/24/07, Krzysztof Halasa <khc@pm.waw.pl> wrote:
> "Satyam Sharma" <satyam.sharma@gmail.com> writes:
>
> > Actually there's another thing :-) The __attribute__((xxx)) must go with the
> > function _declarations_ (and not the implementations/definitions). I noticed
> > after my previous mail that most of the double annotations are actually in
> > the case of the _declarations_ of these non-returning functions, whereas
> > most of the single-occurrences of NORET_TYPE were in the function
> > definitions, which means your patch that simply got rid of NORET_TYPE
> > actually ended up doing exactly the right thing that we wanted :-)
>
> Only half of it. Half of right thing is (here) a bad thing.
>
> NORET_TYPE does not do any harm.
> Removing it removes pointers to attrib((noreturn)) candidates.
> Simple.

NORET_TYPE didn't do any harm because it expanded to /**/. But yes,
removing it does remove the annotations / markers for ATTRIB_NORET
candidates, as I first mentioned to Rday.

But later on going through the code, I noticed that:

1. Most of the combined occurrences of NORET_TYPE along with
ATTRIB_NORET were in function _declarations_. So here, what
we want is to simply remove the NORET_TYPE, and *not* replace
it with ATTRIB_NORET, because it's already there!

2. Most of the single-occurrences (NORET_TYPE alone, without any
ATTRIB_NORET) were in function _implementations_. So here, what
we want is to simply remove the NORET_TYPE, and *not* introduce
any ATTRIB_NORET, because it's not required!

In such a situation, merging a patch that simply gets rid of
NORET_TYPE (i.e. s/NORET_TYPE//) actually ends up doing the
right thing!

... *however* ... as I mentioned next, unfortunately the above 2 points
did not hold for _all_ occurrences of NORET_TYPE. There were
some exceptions (which also I mentioned) where we want to do
somethings slightly more complicated, so I put the ball in Rday's
court -- he had originally expressed a wish to avoid doing complicated
things in this patch.

  parent reply	other threads:[~2007-05-24 17:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 13:09 Robert P. J. Day
2007-05-22 13:53 ` John Anthony Kazos Jr.
2007-05-22 14:01   ` Robert P. J. Day
2007-05-22 14:09     ` Satyam Sharma
2007-05-22 14:16       ` Satyam Sharma
2007-05-22 14:43         ` Krzysztof Halasa
2007-05-22 15:24           ` Satyam Sharma
2007-05-22 19:45           ` Geert Uytterhoeven
2007-05-22 14:47       ` Robert P. J. Day
2007-05-22 13:59 ` Adrian Bunk
2007-05-22 14:04   ` Robert P. J. Day
2007-05-22 16:19     ` Adrian Bunk
2007-05-22 17:04       ` Satyam Sharma
2007-05-22 17:18         ` Robert P. J. Day
2007-05-22 19:25       ` Krzysztof Halasa
2007-05-22 20:17         ` Robert P. J. Day
2007-05-22 20:39           ` Krzysztof Halasa
2007-05-23  8:37             ` Satyam Sharma
2007-05-23 13:09               ` Robert P. J. Day
2007-05-23 13:46                 ` Satyam Sharma
2007-05-24 13:10                   ` Krzysztof Halasa
2007-05-24 13:25                     ` Robert P. J. Day
2007-05-24 17:12                     ` Satyam Sharma [this message]
2007-05-24 16:43                   ` Robert P. J. Day
2007-05-24 18:53                     ` Satyam Sharma
2007-05-25 17:33                       ` Robert P. J. Day
2007-05-25 17:36                       ` Robert P. J. Day
2007-05-25 19:25                         ` Satyam Sharma
2007-05-25 19:40                           ` Robert P. J. Day
2007-05-25 21:46                             ` Adrian Bunk
2007-05-26 21:56                     ` Krzysztof Halasa
2007-05-22 22:41           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a781481a0705241012j513957d8vbc993cb395c31158@mail.gmail.com \
    --to=satyam.sharma@gmail.com \
    --cc=bunk@stusta.de \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®