mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] reverse CONFIG_ACPI_PROC_EVENT default
@ 2007-08-27 15:04 Hugh Dickins
  2007-08-27 17:39 ` Brown, Len
  0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2007-08-27 15:04 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Andrew Morton, Len Brown, linux-kernel

Sigh.  Again an ACPI assault on the Thinkpad's Fn+F4 to suspend to RAM.
The default and text for CONFIG_THINKPAD_ACPI_INPUT_ENABLED were fixed
in -rc3, but now 14e04fb34ffa82ee61ae69f98d8fca12d2e8e31c introduces
CONFIG_ACPI_PROC_EVENT default n to disable it again.  Change default
to y, and add comment to make it clearer that n is for future distros.

Signed-off-by: Hugh Dickins <hugh@veritas.com>

--- 2.6.23-rc3-git10/drivers/acpi/Kconfig	2007-08-26 18:10:15.000000000 +0100
+++ linux/drivers/acpi/Kconfig	2007-08-26 18:59:16.000000000 +0100
@@ -71,6 +71,7 @@ config ACPI_PROCFS
 config ACPI_PROC_EVENT
 	bool "Deprecated /proc/acpi/event support"
 	depends on PROC_FS
+	default y
 	---help---
 	  A user-space daemon, acpi, typically read /proc/acpi/event
 	  and handled all ACPI sub-system generated events.
@@ -78,10 +79,13 @@ config ACPI_PROC_EVENT
 	  These events are now delivered to user-space via
 	  either the input layer, or as netlink events.
 
-	  This build option enables the old code for for legacy
+	  This build option enables the old code for legacy
 	  user-space implementation.  After some time, this will
 	  be moved under CONFIG_ACPI_PROCFS, and then deleted.
 
+	  Say Y here to retain the old behaviour.  Say N if your
+	  user-space is newer than kernel 2.6.23 (September 2007).
+
 config ACPI_AC
 	tristate "AC Adapter"
 	depends on X86

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] reverse CONFIG_ACPI_PROC_EVENT default
  2007-08-27 15:04 [PATCH] reverse CONFIG_ACPI_PROC_EVENT default Hugh Dickins
@ 2007-08-27 17:39 ` Brown, Len
  0 siblings, 0 replies; 2+ messages in thread
From: Brown, Len @ 2007-08-27 17:39 UTC (permalink / raw)
  To: Hugh Dickins, Linus Torvalds; +Cc: Andrew Morton, linux-kernel

Thanks Hugh.

-Len 

>-----Original Message-----
>From: Hugh Dickins [mailto:hugh@veritas.com] 
>Sent: Monday, August 27, 2007 11:05 AM
>To: Linus Torvalds
>Cc: Andrew Morton; Brown, Len; linux-kernel@vger.kernel.org
>Subject: [PATCH] reverse CONFIG_ACPI_PROC_EVENT default
>
>Sigh.  Again an ACPI assault on the Thinkpad's Fn+F4 to suspend to RAM.
>The default and text for CONFIG_THINKPAD_ACPI_INPUT_ENABLED were fixed
>in -rc3, but now 14e04fb34ffa82ee61ae69f98d8fca12d2e8e31c introduces
>CONFIG_ACPI_PROC_EVENT default n to disable it again.  Change default
>to y, and add comment to make it clearer that n is for future distros.
>
>Signed-off-by: Hugh Dickins <hugh@veritas.com>
>
>--- 2.6.23-rc3-git10/drivers/acpi/Kconfig	2007-08-26 
>18:10:15.000000000 +0100
>+++ linux/drivers/acpi/Kconfig	2007-08-26 18:59:16.000000000 +0100
>@@ -71,6 +71,7 @@ config ACPI_PROCFS
> config ACPI_PROC_EVENT
> 	bool "Deprecated /proc/acpi/event support"
> 	depends on PROC_FS
>+	default y
> 	---help---
> 	  A user-space daemon, acpi, typically read /proc/acpi/event
> 	  and handled all ACPI sub-system generated events.
>@@ -78,10 +79,13 @@ config ACPI_PROC_EVENT
> 	  These events are now delivered to user-space via
> 	  either the input layer, or as netlink events.
> 
>-	  This build option enables the old code for for legacy
>+	  This build option enables the old code for legacy
> 	  user-space implementation.  After some time, this will
> 	  be moved under CONFIG_ACPI_PROCFS, and then deleted.
> 
>+	  Say Y here to retain the old behaviour.  Say N if your
>+	  user-space is newer than kernel 2.6.23 (September 2007).
>+
> config ACPI_AC
> 	tristate "AC Adapter"
> 	depends on X86
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-27 17:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-27 15:04 [PATCH] reverse CONFIG_ACPI_PROC_EVENT default Hugh Dickins
2007-08-27 17:39 ` Brown, Len

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®