[PATCH][RFC] Starting point for deprecating "ether=" boot time option.

[PATCH][RFC] Starting point for deprecating "ether=" boot time option.

[Robert P. J. Day]

  i just need a tentative removal date and i can add the appropriate
entry to the feature removal file.  and i can update some of the
appropriate source elsewhere in the tree as well.

diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 12c7657..e4c3b26 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -31,6 +31,8 @@
  *				  older network drivers and IFF_ALLMULTI.
  *	Christer Weinigel	: Better rebuild header message.
  *             Andrew Morton    : 26Feb01: kill ether_setup() - use netdev_boot_setup().
+ *             Robert P. J. Day : Add ether_boot_setup() to allow deprecation warning
+				  for "ether=" boot-time option.
  *
  *		This program is free software; you can redistribute it and/or
  *		modify it under the terms of the GNU General Public License
@@ -60,7 +62,17 @@
 #include <asm/uaccess.h>
 #include <asm/system.h>

-__setup("ether=", netdev_boot_setup);
+static int __init
+ether_boot_setup(char *str)
+{
+	printk(KERN_NOTICE "The 'ether' option is deprecated and "
+		"is scheduled for removal shortly after "
+		"Satan begins ice skating to work\n");
+	printk(KERN_NOTICE "Use 'netdev=<value>' instead\n");
+	return netdev_boot_setup(str);
+}
+
+__setup("ether=", ether_boot_setup);

 /**
  * eth_header - create the Ethernet header

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

Re: [PATCH][RFC] Starting point for deprecating "ether=" boot time option.

[Jan Engelhardt]

On Aug 31 2007 11:47, Robert P. J. Day wrote:
>diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
>index 12c7657..e4c3b26 100644
>--- a/net/ethernet/eth.c
>+++ b/net/ethernet/eth.c
>@@ -31,6 +31,8 @@
>  *				  older network drivers and IFF_ALLMULTI.
>  *	Christer Weinigel	: Better rebuild header message.
>  *             Andrew Morton    : 26Feb01: kill ether_setup() - use netdev_boot_setup().
>+ *             Robert P. J. Day : Add ether_boot_setup() to allow deprecation warning
>+				  for "ether=" boot-time option.

Though I welcome all obsoleting-related stuff,
"the file is not the changelog"; changes to into the SCM log.


	Jan
--