From: Hugh Dickins <hugh@veritas.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/6] LBS: fix oops in try_to_release_page
Date: Fri, 21 Sep 2007 21:46:39 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709212145580.13529@blonde.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0709212141220.6532@blonde.wat.veritas.com>
It's uncommon, but try_to_release_page is sometimes called when
page->mapping is NULL (see the check for mapping further down):
so its VM_BUG_ON(mapping_order(mapping)...) just causes an oops.
There seem to be enough of those checks already, and no special
reason to have one right here: just delete it.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
--- 2.6.23-rc6-lbs/mm/filemap.c 2007-09-11 20:01:08.000000000 +0100
+++ linux/mm/filemap.c 2007-09-14 12:00:06.000000000 +0100
@@ -2247,7 +2247,6 @@ int try_to_release_page(struct page *pag
struct address_space * const mapping = page->mapping;
BUG_ON(!PageLocked(page));
- VM_BUG_ON(mapping_order(mapping) != page_cache_page_order(page));
if (PageWriteback(page))
return 0;
next prev parent reply other threads:[~2007-09-21 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 20:42 [PATCH 1/6] LBS: fix unexported swapper_space Hugh Dickins
2007-09-21 20:45 ` [PATCH 2/6] LBS: fix uninitialized swapper_space Hugh Dickins
2007-09-24 21:16 ` Christoph Lameter
2007-09-26 18:34 ` Hugh Dickins
2007-09-26 18:44 ` Christoph Lameter
2007-09-21 20:45 ` [PATCH 3/6] LBS: fix hang in isolate_lru_pages Hugh Dickins
2007-09-21 20:46 ` Hugh Dickins [this message]
2007-09-21 20:47 ` [PATCH 5/6] LBS: fix crashes in vma_address Hugh Dickins
2007-09-21 20:48 ` [PATCH 6/6] LBS: support largeblocked swapfile Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709212145580.13529@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®