From: Hugh Dickins <hugh@veritas.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
Date: Wed, 26 Sep 2007 19:34:29 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709261926060.8443@blonde.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0709241414270.30982@schroedinger.engr.sgi.com>
On Mon, 24 Sep 2007, Christoph Lameter wrote:
> On Fri, 21 Sep 2007, Hugh Dickins wrote:
>
> > Swapping crashed immediately: must initialize new fields of swapper_space.
>
> Thanks for finding that. It may be better though to use the new
> mapping_setup() function instead? That way there is no #ifdef.
Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP
bdi_init() on swapper_space. Would make sense to do both together,
perhaps move them to a swapper_space_init() in swap_state.c, saving
his #ifdef too. I suggest leave such cleanups until one or the
other is mainlined.
Hugh
next prev parent reply other threads:[~2007-09-26 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 20:42 [PATCH 1/6] LBS: fix unexported swapper_space Hugh Dickins
2007-09-21 20:45 ` [PATCH 2/6] LBS: fix uninitialized swapper_space Hugh Dickins
2007-09-24 21:16 ` Christoph Lameter
2007-09-26 18:34 ` Hugh Dickins [this message]
2007-09-26 18:44 ` Christoph Lameter
2007-09-21 20:45 ` [PATCH 3/6] LBS: fix hang in isolate_lru_pages Hugh Dickins
2007-09-21 20:46 ` [PATCH 4/6] LBS: fix oops in try_to_release_page Hugh Dickins
2007-09-21 20:47 ` [PATCH 5/6] LBS: fix crashes in vma_address Hugh Dickins
2007-09-21 20:48 ` [PATCH 6/6] LBS: support largeblocked swapfile Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709261926060.8443@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®