* [PATCH mm] unionfs: clear partial read
@ 2007-11-09 7:31 Hugh Dickins
2007-11-09 15:26 ` Erez Zadok
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2007-11-09 7:31 UTC (permalink / raw)
To: Erez Zadok; +Cc: Andrew Morton, linux-kernel
unionfs_do_readpage forgot to clear the rest of the page when vfs_read
does not fill the page: fix that.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
fs/unionfs/mmap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- 2.6.24-rc1-mm1/fs/unionfs/mmap.c 2007-11-04 13:48:02.000000000 +0000
+++ linux/fs/unionfs/mmap.c 2007-11-06 13:51:02.000000000 +0000
@@ -176,7 +176,8 @@ static int unionfs_do_readpage(struct fi
err = vfs_read(lower_file, page_data, PAGE_CACHE_SIZE,
&lower_file->f_pos);
set_fs(old_fs);
-
+ if (err >= 0 && err < PAGE_CACHE_SIZE)
+ memset(page_data + err, 0, PAGE_CACHE_SIZE - err);
kunmap(page);
if (err < 0)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH mm] unionfs: clear partial read
2007-11-09 7:31 [PATCH mm] unionfs: clear partial read Hugh Dickins
@ 2007-11-09 15:26 ` Erez Zadok
0 siblings, 0 replies; 2+ messages in thread
From: Erez Zadok @ 2007-11-09 15:26 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Erez Zadok, Andrew Morton, linux-kernel
In message <Pine.LNX.4.64.0711090728130.22720@blonde.wat.veritas.com>, Hugh Dickins writes:
> unionfs_do_readpage forgot to clear the rest of the page when vfs_read
> does not fill the page: fix that.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
>
> fs/unionfs/mmap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- 2.6.24-rc1-mm1/fs/unionfs/mmap.c 2007-11-04 13:48:02.000000000 +0000
> +++ linux/fs/unionfs/mmap.c 2007-11-06 13:51:02.000000000 +0000
> @@ -176,7 +176,8 @@ static int unionfs_do_readpage(struct fi
> err = vfs_read(lower_file, page_data, PAGE_CACHE_SIZE,
> &lower_file->f_pos);
> set_fs(old_fs);
> -
> + if (err >= 0 && err < PAGE_CACHE_SIZE)
> + memset(page_data + err, 0, PAGE_CACHE_SIZE - err);
> kunmap(page);
>
> if (err < 0)
Agreed.
Erez.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-09 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-09 7:31 [PATCH mm] unionfs: clear partial read Hugh Dickins
2007-11-09 15:26 ` Erez Zadok
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®