From: Julia Lawall <julia@diku.dk>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: khali@linux-fr.org, i2c@lm-sensors.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
Date: Wed, 14 Nov 2007 07:09:40 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0711140707120.25487@ask.diku.dk> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711131632490.26111@localhost.localdomain>
>> From: Julia Lawall <julia@diku.dk>
>>
>> Drop #include <linux/moduleparam.h> in files that also include #include
>> <linux/module.h>. module.h includes moduleparam.h already.
>
> i'm not convinced that's a good idea. while module.h does currently
> (and unfortunately) include moduleparam.h, there may come a day when
> those header files are refactored to actually make sense, at which
> point all those missing moduleparam.h inclusions will cause all sorts
> of bad things to happen.
They were removed from the drivers/media files in August:
9c12224a607a4b22ab86784e3394b52810b9507c
Perhaps they should be put back there then?
julia
next prev parent reply other threads:[~2007-11-14 6:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 21:32 Julia Lawall
2007-11-13 21:34 ` Robert P. J. Day
2007-11-14 6:09 ` Julia Lawall [this message]
2007-11-14 9:21 ` Robert P. J. Day
2007-11-15 12:19 ` Jean Delvare
2007-11-15 12:42 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711140707120.25487@ask.diku.dk \
--to=julia@diku.dk \
--cc=i2c@lm-sensors.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®