Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Thu, 15 Nov 2007, Jean Delvare wrote:

... snip ...

> I share Robert's point of view here. Relying on header files
> including each other is usually not a good idea, as build then
> breaks when the headers are cleaned up or reorganized.

... more snip ...

> If there's a fundamental reason why module.h has to include
> moduleparam.h, then both headers should be merged in a single file.
> If not, then both header files should be clearly split and drivers
> should include each of them as needed. Either way, header files must
> be fixed first, and drivers adjusted in consequence. So, I'm not
> taking this patch, sorry.

keeping this short and sweet, i updated my wiki page on this topic:

http://www.crashcourse.ca/wiki/index.php/Module.h_and_moduleparam.h

i think the fundamental question here is whether this is even
cleanable without massive disruption.

rday

--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================