* [PATCH 5/6] drivers/net/hamradio: remove null pointer dereference
@ 2008-05-12 13:38 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2008-05-12 13:38 UTC (permalink / raw)
To: jpr, linux-hams, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
If dev is NULL, it is not possible to access its name field. So I have
simply modified the error message to drop the printing of the name field.
This problem was found using the following semantic match
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@
* if (E == NULL)
{
... when != if (E == NULL) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
--- a/drivers/net/hamradio/yam.c 2008-04-07 13:50:26.000000000 +0200
+++ b/drivers/net/hamradio/yam.c 2008-05-12 09:52:58.000000000 +0200
@@ -1123,8 +1123,7 @@ static int __init yam_init_driver(void)
dev = alloc_netdev(sizeof(struct yam_port), name,
yam_setup);
if (!dev) {
- printk(KERN_ERR "yam: cannot allocate net device %s\n",
- dev->name);
+ printk(KERN_ERR "yam: cannot allocate net device\n");
err = -ENOMEM;
goto error;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-05-12 13:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-12 13:38 [PATCH 5/6] drivers/net/hamradio: remove null pointer dereference Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®