mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] generic GPIO parameter API
Date: Mon, 2 Jun 2008 19:54:36 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0806021949210.30390@axis700.grange> (raw)
In-Reply-To: <Pine.LNX.4.64.0806021841500.30390@axis700.grange>

On Mon, 2 Jun 2008, Guennadi Liakhovetski wrote:

> struct gpio_parameter {
> 	char *name;
> 	void *arg;
> 	int (*get)(struct gpio_chip *chip, void *arg, unsigned offset, 
> 			int value);
> 	int (*set)(struct gpio_chip *chip, void *arg, unsigned offset, 
> 			int value);
> };

The (*get) should have "int *value" of course

> int gpio_register_parameter(struct gpio_chip *chip, struct gpio_parameter 
> 				*param);
> struct gpio_parameter *gpio_find_parameter(struct gpio_chip *chip, char 
> 						*name);

Actually, I think, it would be even better to just add two fields

	struct gpio_parameter	*param;
	int			param_n;

to struct gpio_chip.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer

  reply	other threads:[~2008-06-02 17:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 17:22 Guennadi Liakhovetski
2008-06-02 17:54 ` Guennadi Liakhovetski [this message]
2008-06-02 23:13   ` Ben Nizette
2008-06-03  6:42     ` Guennadi Liakhovetski
2008-06-03  7:32       ` Ben Nizette
2008-06-03  8:29         ` Guennadi Liakhovetski
2008-06-03 22:02           ` Ben Nizette
2008-06-06  5:29 ` David Brownell
2008-06-06  5:50   ` Guennadi Liakhovetski
2008-06-09 16:23   ` Guennadi Liakhovetski
2008-06-09 16:54     ` Mark Brown
2008-06-09 17:09       ` Guennadi Liakhovetski
2008-06-10  9:43         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0806021949210.30390@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®