From: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: dbrownell@users.sourceforge.net,
eric miao <eric.miao@marvell.com>,
spi-devel-general@lists.sourceforge.net
Subject: [PATCH] spi: fix list scan success verification in PXA ssp driver
Date: Thu, 5 Jun 2008 10:37:21 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0806051027340.6598@axis700.grange> (raw)
The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
example, it didn't recognise failure for me when I requested port 0.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
---
arch/arm/mach-pxa/ssp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/arm/mach-pxa/ssp.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:26.000000000 +0200
+++ linux-2.6/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:50.000000000 +0200
@@ -330,7 +330,7 @@
mutex_unlock(&ssp_lock);
- if (ssp->port_id != port)
+ if (&ssp->node == &ssp_list)
return NULL;
return ssp;
next reply other threads:[~2008-06-05 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 8:37 Guennadi Liakhovetski [this message]
2008-06-05 8:45 ` Eric Miao
2008-06-05 8:54 ` eric miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806051027340.6598@axis700.grange \
--to=g.liakhovetski@pengutronix.de \
--cc=dbrownell@users.sourceforge.net \
--cc=eric.miao@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®