mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "eric miao" <eric.y.miao@gmail.com>
To: "Guennadi Liakhovetski" <g.liakhovetski@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
	"eric miao" <eric.miao@marvell.com>,
	spi-devel-general@lists.sourceforge.net,
	"ARM Linux" <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH] spi: fix list scan success verification in PXA ssp driver
Date: Thu, 5 Jun 2008 16:54:44 +0800	[thread overview]
Message-ID: <f17812d70806050154u90fe08cu5ac1e29dbb2ae4d4@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0806051027340.6598@axis700.grange>

Acked-by: Eric Miao <eric.miao@marvell.com>

And this should really go through the ARM tree, please submit the
patch to RMK's patch system. Thanks.

(I have to send this again through my gmail account, please ignore the
other copy if any,
sorry for this)

On Thu, Jun 5, 2008 at 4:37 PM, Guennadi Liakhovetski
<g.liakhovetski@pengutronix.de> wrote:
> The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
> example, it didn't recognise failure for me when I requested port 0.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
>
> ---
>
>  arch/arm/mach-pxa/ssp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/arch/arm/mach-pxa/ssp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c      2008-06-04 12:11:26.000000000 +0200
> +++ linux-2.6/arch/arm/mach-pxa/ssp.c   2008-06-04 12:11:50.000000000 +0200
> @@ -330,7 +330,7 @@
>
>        mutex_unlock(&ssp_lock);
>
> -       if (ssp->port_id != port)
> +       if (&ssp->node == &ssp_list)
>                return NULL;
>
>        return ssp;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Cheers
- eric

      parent reply	other threads:[~2008-06-05  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  8:37 Guennadi Liakhovetski
2008-06-05  8:45 ` Eric Miao
2008-06-05  8:54 ` eric miao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d70806050154u90fe08cu5ac1e29dbb2ae4d4@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eric.miao@marvell.com \
    --cc=g.liakhovetski@pengutronix.de \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®