From: Mikulas Patocka <mpatocka@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: David Miller <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
jens.axboe@oracle.com
Subject: Re: [SUGGESTION]: drop virtual merge accounting in I/O requests
Date: Sun, 13 Jul 2008 19:53:01 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0807131947090.7803@devserv.devel.redhat.com> (raw)
In-Reply-To: <487A61DD.6090304@firstfloor.org>
On Sun, 13 Jul 2008, Andi Kleen wrote:
> David Miller wrote:
>> From: Andi Kleen <andi@firstfloor.org>
>> Date: Sun, 13 Jul 2008 15:50:55 +0200
>>
>>> Still I would expect that modern IO controllers are typically fast
>>> enough at processing SG lists that it shouldn't matter much.
>>
>> I know it matters a lot on sparc64 ESP scsi controllers.
>>
>> You can only have one address/len pair DMA'ing at a time and you have
>> to service an interrupt to load in the the next DMA sg elements into
>> the chips registers.
>>
>> Merging is essentially a must for performance on those cards.
>
> Well right now your setup breaks all controllers with "weird requirements"
> like 64k DMA or similar. You'll need to find some way to turn off BIO
> merge for those at least.
>
> Perhaps this needs to be really a block queue attribute instead of a global?
>
> -Andi
There is no need to turn BIO merge off --- the problem is caused by
accounting of BIO merging in block layer, not by BIO merging itself.
Just do #define BIO_VMERGE_BOUNDARY 0, and that disables the accounting,
but leaves merging as it is.
Mikulas
next prev parent reply other threads:[~2008-07-13 23:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 21:56 Mikulas Patocka
2008-07-10 22:59 ` Julian Calaby
2008-07-10 23:57 ` Mikulas Patocka
2008-07-11 6:20 ` FUJITA Tomonori
2008-07-11 10:52 ` Mikulas Patocka
2008-07-11 11:15 ` FUJITA Tomonori
2008-07-11 19:41 ` David Miller
2008-07-11 20:22 ` Mikulas Patocka
2008-07-12 12:30 ` Andi Kleen
2008-07-13 13:34 ` Mikulas Patocka
2008-07-13 13:50 ` Andi Kleen
2008-07-13 19:46 ` David Miller
2008-07-13 20:13 ` Andi Kleen
2008-07-13 23:53 ` Mikulas Patocka [this message]
2008-07-14 0:48 ` David Miller
2008-07-14 12:16 ` Mikulas Patocka
2008-07-14 12:28 ` David Miller
2008-07-14 14:03 ` Mikulas Patocka
2008-07-14 21:37 ` David Miller
2008-07-14 23:16 ` Mikulas Patocka
2008-07-15 1:31 ` David Miller
2008-07-15 22:32 ` Mikulas Patocka
2008-07-15 22:37 ` David Miller
2008-07-15 22:59 ` Mikulas Patocka
2008-07-15 2:40 ` FUJITA Tomonori
2008-07-14 0:41 ` David Miller
2008-07-14 2:19 ` FUJITA Tomonori
2008-07-14 3:20 ` David Miller
2008-07-14 17:45 ` FUJITA Tomonori
2008-07-14 21:26 ` Mikulas Patocka
2008-07-15 2:40 ` FUJITA Tomonori
2008-07-15 12:09 ` Mikulas Patocka
2008-07-15 12:15 ` Andi Kleen
2008-07-15 13:16 ` Mikulas Patocka
2008-07-15 14:06 ` Andi Kleen
2008-07-15 12:19 ` FUJITA Tomonori
2008-07-16 3:10 ` David Miller
2008-07-16 4:38 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0807131947090.7803@devserv.devel.redhat.com \
--to=mpatocka@redhat.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome