* [PATCH 3/7] drivers/net/wireless/b43legacy/main.c: Release mutex in error handling code
@ 2008-07-21 7:57 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2008-07-21 7:57 UTC (permalink / raw)
To: Larry.Finger, stefano.brivio, linux-wireless, jgarzik,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.
The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression l;
@@
mutex_lock(l);
... when != mutex_unlock(l)
when any
when strict
(
if (...) { ... when != mutex_unlock(l)
+ mutex_unlock(l);
return ...;
}
|
mutex_unlock(l);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -3862,10 +3862,10 @@ static int b43legacy_resume(struct ssb_d
goto out;
}
}
- mutex_unlock(&wl->mutex);
b43legacydbg(wl, "Device resumed.\n");
out:
+ mutex_unlock(&wl->mutex);
return err;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-07-21 7:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-21 7:57 [PATCH 3/7] drivers/net/wireless/b43legacy/main.c: Release mutex in error handling code Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®