Re: linux-next: ttydev tree build failure

Re: linux-next: ttydev tree build failure

[Geert Uytterhoeven]

On Wed, 23 Jul 2008, Alan Cox wrote:
> > Update all drivers when making core tty infrastructure changes?
> > Thanks!
> 
> I don't have an Amiga with that board, I don't have an obscure VME 68K
> board. The changes required at this point would be tricky to verify
> without hardware, and the upcoming changes will require significant
> changes to all the hardware drivers, which will need someone to actually
> maintain the drivers, or to drop them.

IC, testing/maintaining non-trival changes is a different situation.

But it would still be nice to announce such removals/breakings in advance,
cfr. Documentation/feature-removal-schedule.txt. At least we knew the old
NCR53C9x core was going away, taken with it all drivers depending on it...

Anyone who cares about these drivers (ser_a2232 and vme_scc, perhaps
others?)?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

linux-next: ttydev tree build failure

[Stephen Rothwell]

Hi Alan,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/serial/pmac_zilog.c: In function 'pmz_suspend':
drivers/serial/pmac_zilog.c:1648: error: 'struct uart_state' has no member named 'mutex'
drivers/serial/pmac_zilog.c:1679: error: 'struct uart_state' has no member named 'mutex'
drivers/serial/pmac_zilog.c: In function 'pmz_resume':
drivers/serial/pmac_zilog.c:1708: error: 'struct uart_state' has no member named 'mutex'
drivers/serial/pmac_zilog.c:1740: error: 'struct uart_state' has no member named 'mutex'

Caused by commit d7b52714eee196caeb4195ae1a7aa8bf82bffda5
("serial-move-mutex") from the ttydev tree.

I applied the following patch for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 24 Jul 2009 15:48:36 +1000
Subject: [PATCH] serial: fix pmac_zilog fallout from uart_state mutex move

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/serial/pmac_zilog.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/serial/pmac_zilog.c b/drivers/serial/pmac_zilog.c
index 6495d01..0700cd1 100644
--- a/drivers/serial/pmac_zilog.c
+++ b/drivers/serial/pmac_zilog.c
@@ -1645,7 +1645,7 @@ static int pmz_suspend(struct macio_dev *mdev, pm_message_t pm_state)
 	state = pmz_uart_reg.state + uap->port.line;
 
 	mutex_lock(&pmz_irq_mutex);
-	mutex_lock(&state->mutex);
+	mutex_lock(&state->port.mutex);
 
 	spin_lock_irqsave(&uap->port.lock, flags);
 
@@ -1676,7 +1676,7 @@ static int pmz_suspend(struct macio_dev *mdev, pm_message_t pm_state)
 	/* Shut the chip down */
 	pmz_set_scc_power(uap, 0);
 
-	mutex_unlock(&state->mutex);
+	mutex_unlock(&state->port.mutex);
 	mutex_unlock(&pmz_irq_mutex);
 
 	pmz_debug("suspend, switching complete\n");
@@ -1705,7 +1705,7 @@ static int pmz_resume(struct macio_dev *mdev)
 	state = pmz_uart_reg.state + uap->port.line;
 
 	mutex_lock(&pmz_irq_mutex);
-	mutex_lock(&state->mutex);
+	mutex_lock(&state->port.mutex);
 
 	spin_lock_irqsave(&uap->port.lock, flags);
 	if (!ZS_IS_OPEN(uap) && !ZS_IS_CONS(uap)) {
@@ -1737,7 +1737,7 @@ static int pmz_resume(struct macio_dev *mdev)
 	}
 
  bail:
-	mutex_unlock(&state->mutex);
+	mutex_unlock(&state->port.mutex);
 	mutex_unlock(&pmz_irq_mutex);
 
 	/* Right now, we deal with delay by blocking here, I'll be
-- 
1.6.3.3

linux-next: ttydev tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi Alan,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/serial/icom.c: In function 'check_modem_status':
drivers/serial/icom.c:697: error: 'struct uart_state' has no member named 'delta_msr_wait'

Caused by commit d663043b15626a1917587386da503e7943e434f6
("serial-kill-info").

So again I have used the ttydev tree from next-20090713.  Not having much
luck :-(
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: ttydev tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi Alan,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

In file included from drivers/serial/8250.c:37:
include/linux/serial_core.h: In function 'uart_handle_sysrq_char':
include/linux/serial_core.h:445: error: 'struct uart_port' has no member named 'info'

I have used the version of the ttydev tree from next-20090713 (the last
error free one).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: ttydev tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

Hi Alan,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/serial/serial_core.c: In function 'uart_close':
drivers/serial/serial_core.c:1341: error: 'struct tty_port' has no member named 'cons'
drivers/serial/serial_core.c:1341: error: 'struct tty_port' has no member named 'cons'
drivers/serial/serial_core.c:1341: error: 'struct tty_port' has no member named 'line'

Caused by commit 85325e93e9473dd779e8378c1365f9d8a11f9b9e
("serial-port-portptr").

I have used the version of the ttydev tree from next-20090713 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: ttydev tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi Alan,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "pm_set_vt_switch" [drivers/video/geode/lxfb.ko] undefined!
ERROR: "pm_set_vt_switch" [drivers/video/geode/gxfb.ko] undefined!

Caused by commit 2da31885ce1c33ac1bed80857ad5c9de2b95a189
("vt-pm-extract") which renamed pm_set_vt_switch to pm_vt_set_switch.

I have used the version of the ttydev tree from next-20090703 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]