From: Hugh Dickins <hugh@veritas.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>,
Ben Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] linux/swap.h must #include <linux/pagemap.h>
Date: Sat, 26 Jul 2008 22:05:34 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0807262155160.17736@blonde.site> (raw)
In-Reply-To: <20080726204218.GG9301@cs181140183.pp.htv.fi>
On Sat, 26 Jul 2008, Adrian Bunk wrote:
> On Sat, Jul 26, 2008 at 09:37:45PM +0100, Hugh Dickins wrote:
> >
> > I've trespassed on Adrian's good nature to ask him to run some builds
> > on it, having demonstrated my incompetence twice already. But he may
> > well have better things to do with his time. Hold on a mo, I'm just
> > wrapping up the tmpfs BUG first.
>
> Sorry, if you wanted to know anything from me anything except whether my
> patch is correct (as I already answered to Johannes it is not) I must
> have missed it.
>
> What exactly do you want me to test?
It was this one, just including pagemap.h back in exec.c again:
not the best solution, but should be good for now. Please would
you give it the build testing you were giving yours? Or feel free
to point out that I'm wasting your and everybody's time, and just
call for a straight revert of ba92a43d, that'd be fine too.
Thanks,
Hugh
--- 2.6.26-git/fs/exec.c 2008-07-26 12:33:28.000000000 +0100
+++ linux/fs/exec.c 2008-07-26 18:50:38.000000000 +0100
@@ -32,6 +32,7 @@
#include <linux/swap.h>
#include <linux/string.h>
#include <linux/init.h>
+#include <linux/pagemap.h>
#include <linux/highmem.h>
#include <linux/spinlock.h>
#include <linux/key.h>
next prev parent reply other threads:[~2008-07-26 21:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 17:18 [PATCH] include/asm-generic/tlb.h must include <linux/pagemap.h> Haavard Skinnemoen
2008-07-26 17:38 ` [2.6 patch] linux/swap.h must #include <linux/pagemap.h> Adrian Bunk
2008-07-26 17:59 ` Johannes Weiner
2008-07-26 18:07 ` Adrian Bunk
2008-07-26 18:13 ` Hugh Dickins
2008-07-26 19:50 ` Andrew Morton
2008-07-26 20:15 ` Hugh Dickins
2008-07-26 20:26 ` Andrew Morton
2008-07-26 20:37 ` Hugh Dickins
2008-07-26 20:42 ` Adrian Bunk
2008-07-26 21:05 ` Hugh Dickins [this message]
2008-07-27 13:04 ` Adrian Bunk
2008-07-27 13:40 ` Hugh Dickins
2008-07-27 13:43 ` [PATCH] exec: include pagemap.h again to fix build Hugh Dickins
2008-07-26 18:30 ` [2.6 patch] linux/swap.h must #include <linux/pagemap.h> Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0807262155160.17736@blonde.site \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®