From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>,
Ben Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] exec: include pagemap.h again to fix build
Date: Sun, 27 Jul 2008 14:43:38 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0807271441010.32444@blonde.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0807271437330.32444@blonde.site>
Fix compilation errors on avr32 and without CONFIG_SWAP, introduced by
ba92a43dbaee339cf5915ef766d3d3ffbaaf103c exec: remove some includes
In file included from include/asm/tlb.h:24,
from fs/exec.c:55:
include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages'
include/asm-generic/tlb.h: In function 'tlb_remove_page':
include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'
make[1]: *** [fs/exec.o] Error 1
This straightforward part-revert is nobody's favourite patch to address
the underlying tlb.h needs swap.h needs pagemap.h (but sparc won't like
that) mess; but appropriate to fix the build now before any overhaul.
Reported-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Reported-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Tested-by: Adrian Bunk <bunk@kernel.org>
---
fs/exec.c | 1 +
1 file changed, 1 insertion(+)
--- 2.6.26-git/fs/exec.c 2008-07-26 12:33:28.000000000 +0100
+++ linux/fs/exec.c 2008-07-26 18:50:38.000000000 +0100
@@ -32,6 +32,7 @@
#include <linux/swap.h>
#include <linux/string.h>
#include <linux/init.h>
+#include <linux/pagemap.h>
#include <linux/highmem.h>
#include <linux/spinlock.h>
#include <linux/key.h>
next prev parent reply other threads:[~2008-07-27 13:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 17:18 [PATCH] include/asm-generic/tlb.h must include <linux/pagemap.h> Haavard Skinnemoen
2008-07-26 17:38 ` [2.6 patch] linux/swap.h must #include <linux/pagemap.h> Adrian Bunk
2008-07-26 17:59 ` Johannes Weiner
2008-07-26 18:07 ` Adrian Bunk
2008-07-26 18:13 ` Hugh Dickins
2008-07-26 19:50 ` Andrew Morton
2008-07-26 20:15 ` Hugh Dickins
2008-07-26 20:26 ` Andrew Morton
2008-07-26 20:37 ` Hugh Dickins
2008-07-26 20:42 ` Adrian Bunk
2008-07-26 21:05 ` Hugh Dickins
2008-07-27 13:04 ` Adrian Bunk
2008-07-27 13:40 ` Hugh Dickins
2008-07-27 13:43 ` Hugh Dickins [this message]
2008-07-26 18:30 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0807271441010.32444@blonde.site \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®