mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Greg Ungerer <gerg@snapgear.com>,
	jbarnes@virtuousgeek.org,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org,
	Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [2.6 patch] m68k: remove the dead PCI code
Date: Wed, 3 Sep 2008 09:22:52 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0809030922280.17860@anakin> (raw)
In-Reply-To: <20080831161016.GE3695@cs181140183.pp.htv.fi>

On Sun, 31 Aug 2008, Adrian Bunk wrote:
> On Fri, Aug 29, 2008 at 09:31:43AM +0200, Geert Uytterhoeven wrote:
> > On Fri, 29 Aug 2008, Adrian Bunk wrote:
> > > On Fri, Aug 29, 2008 at 02:13:24PM +1000, Greg Ungerer wrote:
> > > > Adrian Bunk wrote:
> > > >> A patch for removing the comempci code is below.
> > > >>
> > > >> It's a bit suspicious that asm/elia.h is now removed since comempci.c  
> > > >> was the only user. What's the sttus of the eLIA platform?
> > > >
> > > > Only ever a handful where made, and that was in 1999.
> > > > I doubt anyone could ever use the PCI interface on it
> > > > in any useful way.
> > > 
> > > So I can send a patch to remove the platform?
> > > 
> > > >> But COMEMPCI fails with a different error - this init/main.o build 
> > > >> error is present for CONFIG_PCI=y, CONFIG_COMEMPCI=n, so the dependency 
> > > >> of PCI on BROKEN is still required (unless it gets fixed).
> > > >
> > > > Unless I am mistaken there is now no need for the CONFIG_PCI option
> > > > if selecting m68knommu. The only m68knommu platforms that had PCI
> > > > as far as I know where those that use the comempci part.
> > > 
> > > That implies I can also kill the m68k PCI code since m68knommu will 
> > > never use it?
> > 
> > Sure. If the FreeScale guys ever forward-port their ColdFire/MMU code to
> > current mainline, we can readd it.
> 
> Patch (on top of my Hades removal patch) is below.
> 
> cu
> Adrian
> 
> 
> <--  snip    -->
> 
> 
> This patch removes the no longer used m68k PCI code.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Thanks! Will queue for 2.6.28, too.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

  reply	other threads:[~2008-09-03  7:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 13:47 [2.6 patch] m68knommu: let PCI depend on BROKEN Adrian Bunk
2008-08-19 14:13 ` Geert Uytterhoeven
2008-08-19 14:32   ` Adrian Bunk
2008-08-19 15:05 ` Matthew Wilcox
2008-08-22  3:44   ` Bryan Wu
2008-08-25  6:16 ` Greg Ungerer
2008-08-25 20:43   ` [RFC: 2.6 patch] m68knommu: remove the broken COMEMPCI code Adrian Bunk
2008-08-29  4:13     ` Greg Ungerer
2008-08-29  7:01       ` Adrian Bunk
2008-08-29  7:31         ` Geert Uytterhoeven
2008-08-31 16:10           ` [2.6 patch] m68k: remove the dead PCI code Adrian Bunk
2008-09-03  7:22             ` Geert Uytterhoeven [this message]
2008-09-06 12:23             ` Geert Uytterhoeven
2008-09-09  5:06               ` Jesse Barnes
2008-09-09  7:11                 ` Geert Uytterhoeven
2008-09-25 13:31               ` Adrian Bunk
2008-08-29 11:07         ` [RFC: 2.6 patch] m68knommu: remove the broken COMEMPCI code Greg Ungerer
2008-08-31 16:10           ` [2.6 patch] m68knommu: remove the eLIA support Adrian Bunk
2008-08-31 16:10       ` [2.6 patch] m68knommu: remove the unused PCI option Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0809030922280.17860@anakin \
    --to=geert@linux-m68k.org \
    --cc=bunk@kernel.org \
    --cc=gerg@snapgear.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®