* [PATCH] <linux/pci.h> needs <linux/io.h> for ioremap_nocache()
@ 2008-10-22 6:50 Geert Uytterhoeven
0 siblings, 0 replies; only message in thread
From: Geert Uytterhoeven @ 2008-10-22 6:50 UTC (permalink / raw)
To: Linus Torvalds, ArjanvandeVen, Jesse Barnes
Cc: linux-pci, Linux Kernel Development
commit aa42d7c6138afdc54f74e971456a0fbfec16b77b ("PCI: introduce an
pci_ioremap(pdev, barnr) function") added a static inline function that calls
ioremap_nocache(), causing a compile error on m68k:
| In file included from drivers/ide/ide.c:58:
| include/linux/pci.h: In function 'pci_ioremap_bar':
| include/linux/pci.h:1132: error: implicit declaration of function 'ioremap_nocache'
| include/linux/pci.h:1133: warning: return makes pointer from integer without a cast
| In file included from include/linux/bio.h:30,
| from include/linux/blkdev.h:17,
| from include/linux/ide.h:13,
| from drivers/ide/ide.c:59:
Include <linux/io.h> to provide the prototype for ioremap_nocache().
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
FWIW...
Discovered in the linux-next builds on Oct 21, which was actually the one of
Oct 20 (Ozlabs time)
Discovered in the mainline builds two day later
include/linux/pci.h | 1 +
1 file changed, 1 insertion(+)
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -44,6 +44,7 @@
#include <linux/types.h>
#include <linux/init.h>
+#include <linux/io.h>
#include <linux/ioport.h>
#include <linux/list.h>
#include <linux/compiler.h>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-22 6:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-22 6:50 [PATCH] <linux/pci.h> needs <linux/io.h> for ioremap_nocache() Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®