From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
linux-arm-kernel@lists.arm.linux.org.uk,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 2/4 v4] i.MX31: Image Processing Unit DMA and IRQ drivers
Date: Tue, 23 Dec 2008 12:21:54 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0812231157180.5188@axis700.grange> (raw)
In-Reply-To: <20081223105006.GE1614@pengutronix.de>
Hi Sascha
On Tue, 23 Dec 2008, Sascha Hauer wrote:
> On Mon, Dec 22, 2008 at 09:10:03PM +0100, Guennadi Liakhovetski wrote:
> >
> > Ok, so, what would we like to have there? We agree that the proper way to
> > serve them is a irq-chip driver, right?
>
> In case of the *_EOF interrupts when they can be used outside the idmac
> driver then yes. If not then not for the reasons I explained.
Wait a minute, are you suggesting to handle interrupts that are exported
to client drivers and that are "internal" to ipu_idmac differently? Like
exported once - properly using the irq chip machinery, and internal once
just demux in the driver hiding them from the kernel?... Or have I
misunderstood you? If this is indeed what you mean, then that doesn't
sound like a good idea to me, sorry. Like you configure a chained handler,
then when it is called on an IRQ, you check if the reason is bits 0, 1, or
2 you call generic_handle_irq(), for other bits you handle them
internally... grrrr... And, in fact, I don't see many internal interrupts
there - maybe only those from IPU_INT_STAT_3 related to CM? You see, we
could split interrupts further: support for EOF irqs - unconditional,
error, NF, and IPU_INT_STAT_3 IRQs - under 3 config variables, maybe even
split IPU_INT_STAT_3 further in submodules... But this would clutter the
Kconfig. Ok, I could add an own Kconfig under drivers/dma/ipu. But I
really do not think we should export some interrupts to the irq_desc array
and handle others internally. So, what granularity would you like to see
there?
> > > Another thing is the overlay framebuffer. I think it's mainly useful to
> > > display video streams. Maybe it's better to implement this as a v4l
> > > device as unlike the framebuffer API the v4l API is designed to handle
> > > different image buffers.
> > > These things just popped up in my mind, I don't know if they are
> > > practical, I still have a quite limited understanding of the whole
> > > imaging stuff on the MX31.
> >
> > You mean an output v4l device? I think overlays are handled by framebuffer
> > drivers... But I'm also not quite sure about it, however, handling overlay
> > as another framebuffer seems logical to me.
>
> Well the DMA engine seems to suggest that frames should be passed around
> whereas the framebuffer API only has a single frame. That would fit
> better into the v4l API. Also the IPU can do things like colourspace
> conversion and hw scaling which would fit into the V4L API.
> OTOH there are not many examples of drivers doing this (ivtv, zoran in
> kernel and an Omap driver found on lists). And I haven't found any
> application supporting a V4L output device.
> BTW is the overlay framebuffer useful in it's current implementation?
> There seems to be no way to adjust the x/y offset or the blending modes.
No - that's what the comment in the commit says:
This is a framebuffer driver for i.MX31 SoCs. It only supports synchronous
displays, overlay support is included but has never been tested.
[Oops, just noticed - in v5 framebuffer I again have the "panning not
tested" clause, which is not true, and the comment has been fixed in v4:-(
So, if we decide to take v5, we'd have to take the comment from v4]
So, I could just throw overlay completely out. OTOH, if anyone ever wants
to use it, they'll have something to start with.
> > If there are no other problems with v5, could we maybe take it as a basis
> > and then I would submit a patch to reduce the number of IRQs?
>
> Please understand my concerns with this driver. It's a quite complex
> beast and experience shows that once a driver is in the kernel it is far
> more complicated to change it than to do it right the first way. You
> know that I'm also interested in having a MX31 framebuffer (and camera)
> driver in kernel but I want to make sure that it works properly and leaves
> room for feature enhancements without having to refactor the whole
> driver.
Well, not quite so. At least with my workflow it takes more work to
regenerate a complete patch-series, than to create incremental patches.
For me it would be definitely easier to have a version of the driver
upstream to then only create incremental patches for it. Also, it would be
easier for others to test it. And consider the constantly moving target
effect - you know it as well as I do, rebasing your off-tree patches to
new kernel versions is a considerable amount of work too.
> It would be good if someone else could throw his 2 cents into this
> discussion.
Yes, eventually, the drivers will have to go over dma and framebuffer
trees...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
next prev parent reply other threads:[~2008-12-23 11:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 13:26 [PATCH 0/4 v4] i.MX31: dmaengine and framebuffer drivers Guennadi Liakhovetski
2008-12-18 13:26 ` [PATCH 1/4 v4] dmaengine: add async_tx_clear_ack() macro Guennadi Liakhovetski
2008-12-18 13:26 ` [PATCH 2/4 v4] i.MX31: Image Processing Unit DMA and IRQ drivers Guennadi Liakhovetski
2008-12-18 22:58 ` Sascha Hauer
2008-12-22 11:56 ` Guennadi Liakhovetski
2008-12-22 18:37 ` Sascha Hauer
2008-12-22 20:03 ` Robert Schwebel
2008-12-23 10:09 ` Dmitry Krivoschekov
2008-12-23 10:52 ` Sascha Hauer
2008-12-23 11:32 ` Dmitry Krivoschekov
2008-12-23 12:08 ` Sascha Hauer
2008-12-22 20:10 ` Guennadi Liakhovetski
2008-12-23 10:50 ` Sascha Hauer
2008-12-23 11:21 ` Guennadi Liakhovetski [this message]
2008-12-23 12:50 ` Sascha Hauer
2008-12-23 13:14 ` Guennadi Liakhovetski
2008-12-23 14:03 ` Sascha Hauer
2008-12-23 14:55 ` Guennadi Liakhovetski
2008-12-23 16:09 ` Sascha Hauer
2008-12-23 16:33 ` Guennadi Liakhovetski
2008-12-23 17:14 ` Sascha Hauer
2008-12-23 12:13 ` Robert Schwebel
2008-12-23 12:45 ` Guennadi Liakhovetski
2008-12-23 12:56 ` Sascha Hauer
2008-12-23 12:56 ` Valentin Longchamp
2008-12-18 13:26 ` [PATCH 3/4 v4] i.MX31: framebuffer driver Guennadi Liakhovetski
2008-12-18 13:27 ` [PATCH 4/4 v4] i.MX31: platform bindings and initialisation for IPU and framebuffer drivers Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812231157180.5188@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=adaplas@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®