mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: gregkh@suse.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 5/5] staging/otus: Move a dereference below a NULL test
Date: Sat, 11 Jul 2009 09:51:14 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0907110950510.29592@ask.diku.dk> (raw)

From: Julia Lawall <julia@diku.dk>

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/staging/otus/wwrap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
--- a/drivers/staging/otus/wwrap.c
+++ b/drivers/staging/otus/wwrap.c
@@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
 {
     struct usbdrv_private *macp =
                container_of(work, struct usbdrv_private, kevent);
-    zdev_t *dev = macp->device;
+    zdev_t *dev;
 
     if (macp == NULL)
     {
         return;
     }
+    dev = macp->device;
 
     if (test_and_set_bit(0, (void *)&smp_kevent_Lock))
     {

             reply	other threads:[~2009-07-11  7:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11  7:51 Julia Lawall [this message]
2009-07-11  8:17 ` Jiri Slaby
2009-07-11  8:31   ` Julia Lawall
2009-07-11 10:17   ` Jaswinder Singh Rajput
2009-07-11 10:32     ` Jaswinder Singh Rajput
2009-07-11 11:09       ` Jiri Slaby
2009-07-13 17:00         ` Luis R. Rodriguez
2009-07-11 11:06     ` Jiri Slaby
2009-07-11 11:32       ` Julia Lawall
2009-07-11 11:58         ` Julia Lawall
2009-07-11 17:03   ` Greg KH
2009-07-11 18:28     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0907110950510.29592@ask.diku.dk \
    --to=julia@diku.dk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®