* [PATCH 5/5] net/irda: Drop unnecessary NULL test
@ 2009-07-12 20:06 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2009-07-12 20:06 UTC (permalink / raw)
To: samuel, irda-users, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The result of container_of should not be NULL. In particular, in this case
the argument to the enclosing function has passed though INIT_WORK, which
dereferences it, implying that its container cannot be NULL.
A simplified version of the semantic patch that makes this change is as
follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
identifier fn,work,x,fld;
type T;
expression E1,E2;
statement S;
@@
static fn(struct work_struct *work) {
... when != work = E1
x = container_of(work,T,fld)
... when != x = E2
- if (x == NULL) S
...
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
net/irda/irnet/irnet_irda.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/irda/irnet/irnet_irda.c b/net/irda/irnet/irnet_irda.c
index cf9a4b5..49ed80d 100644
--- a/net/irda/irnet/irnet_irda.c
+++ b/net/irda/irnet/irnet_irda.c
@@ -21,8 +21,6 @@ static void irnet_ppp_disconnect(struct work_struct *work)
irnet_socket * self =
container_of(work, irnet_socket, disconnect_work);
- if (self == NULL)
- return;
/*
* If we were connected, cleanup & close the PPP
* channel, which will kill pppd (hangup) and the rest.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-12 20:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-12 20:06 [PATCH 5/5] net/irda: Drop unnecessary NULL test Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®