mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/2] net/irda/ircomm: Drop unnecessary NULL test
@ 2009-07-13 10:10 Julia Lawall
  0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2009-07-13 10:10 UTC (permalink / raw)
  To: samuel, irda-users, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

The result of container_of should not be NULL.  In particular, in this case
the argument to the enclosing function has passed though INIT_WORK,
which dereferences it, implying that its container cannot be NULL.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression x,e;
@@

x = container_of(...)
... when != x = e
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 net/irda/ircomm/ircomm_tty.c        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c
index 811984d..6306c19 100644
--- a/net/irda/ircomm/ircomm_tty.c
+++ b/net/irda/ircomm/ircomm_tty.c
@@ -609,7 +609,7 @@ static void ircomm_tty_do_softint(struct work_struct *work)
 
 	IRDA_DEBUG(2, "%s()\n", __func__ );
 
-	if (!self || self->magic != IRCOMM_TTY_MAGIC)
+	if (self->magic != IRCOMM_TTY_MAGIC)
 		return;
 
 	tty = self->tty;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-13 10:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-13 10:10 [PATCH 2/2] net/irda/ircomm: Drop unnecessary NULL test Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®