[PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom <jodarom@sdf.org>
Cc: <stable@vger.kernel.org>
---
  Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27

  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters

  drivers/platform/x86/ideapad-laptop.c |   14 ++++++++++++++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c	2016-02-14 15:05:20.000000000 -0600
+++ b/drivers/platform/x86/ideapad-laptop.c	2016-02-16 03:54:48.484423725 -0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
  			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
 		},
+	},
+	{
+		.ident = "Lenovo ideapad Y700-15ISK",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700-15ISK"),
+		},
+	},
+	{
+		.ident = "Lenovo ideapad Y700 Touch-15ISK",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 Touch-15ISK"),
+		},
  	},
  	{

Re: [PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[Darren Hart]

On Thu, Feb 18, 2016 at 01:42:20AM -0600, John Dahlstrom wrote:
> Some Lenovo ideapad models lack a physical rfkill switch.
> On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
> ideapad-laptop would wrongly report all radios as blocked by
> hardware which caused wireless network connections to fail.
> 
> Add these models without an rfkill switch to the no_hw_rfkill list.
> 
> Signed-off-by: John Dahlstrom <jodarom@sdf.org>
> Cc: <stable@vger.kernel.org>
> ---
>  Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27

See stable_kernel_rules.txt for how to specify relevant versions. I'm curious
why there is a gap from 3.18 to 4.1.

What you probably meant was:

Cc: <stable@vger.kernel.org> # 3.18.x

If you are going to take this approach, you may wish to verify that this applies
back to 3.18, otherwise you may need to specify dependencies (also described in
the stable_kernel_rules).

My recommendation would be to simply leave the version off and let Greg and the
other maintainers decide how far back to apply it, unless you really care about
3.18 working on these laptops.

If you don't mind leaving it up to them I can take this as is, otherwise, you'll
need to update the Cc stable lines accordingly.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Fri, 19 Feb 2016, Darren Hart wrote:

> See stable_kernel_rules.txt for how to specify relevant versions. I'm curious
> why there is a gap from 3.18 to 4.1.
>
> What you probably meant was:
>
> Cc: <stable@vger.kernel.org> # 3.18.x
>
> If you are going to take this approach, you may wish to verify that this applies
> back to 3.18, otherwise you may need to specify dependencies (also described in
> the stable_kernel_rules).
>

Darren,

Thank you for your assistance.

The version gap in the earlier v3 comment reflected my earlier gap in 
verification. Today I stepped through the additional kernel versions to 
confirm the patch applies successfully to those versions, and have 
submitted the patch as v4.

Kernel version 3.18.27 already handles the 17" model of the ideapad Y700, 
so it would seem odd not to also handle the 15" model.

Kind regards,

John

Re: [PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[Darren Hart]

On Fri, Feb 19, 2016 at 08:01:17PM -0600, John Dahlstrom wrote:
> On Fri, 19 Feb 2016, Darren Hart wrote:
> 
> >See stable_kernel_rules.txt for how to specify relevant versions. I'm curious
> >why there is a gap from 3.18 to 4.1.
> >
> >What you probably meant was:
> >
> >Cc: <stable@vger.kernel.org> # 3.18.x
> >
> >If you are going to take this approach, you may wish to verify that this applies
> >back to 3.18, otherwise you may need to specify dependencies (also described in
> >the stable_kernel_rules).
> >
> 
> Darren,
> 
> Thank you for your assistance.
> 
> The version gap in the earlier v3 comment reflected my earlier gap in
> verification. Today I stepped through the additional kernel versions to
> confirm the patch applies successfully to those versions, and have submitted
> the patch as v4.

In this case, the patch should only have a single Cc line to stable:

Cc: <stable@vger.kernel.org> # 3.18.x

I'll make the adjustment from your v4 myself to save you the resend ;-)

> 
> Kernel version 3.18.27 already handles the 17" model of the ideapad Y700, so
> it would seem odd not to also handle the 15" model.

We backport until it doesn't apply, but shouldn't be skipping versions as we go
back, that would be simply unmaintainable. So I'll mark it as 3.18.x.

-- 
Darren Hart
Intel Open Source Technology Center