2.4 compile errors in 32-bit sys_revcmsg fixes

2.4 compile errors in 32-bit sys_revcmsg fixes

[Meelis Roos]

This is todays 2.4.30-pre1+BK snapshot on a sparc64:

gcc -D__ASSEMBLY__ -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -m64 -mcpu=ultrasparc -Wa,--undeclared-regs -ansi  -c -o sys32.o sys32.S
gcc -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -m64 -pipe -mno-fpu -mcpu=ultrasparc -mcmodel=medlow -ffixed-g4 -fcall-used-g5 -fcall-used-g7 -Wno-sign-compare -Wa,--undeclared-regs -finline-limit=100000   -nostdinc -iwithprefix include -DKBUILD_BASENAME=sys_sparc32  -c -o 
sys_sparc32.o sys_sparc32.c
sys_sparc32.c: In function `cmsg32_recvmsg_fixup':
sys_sparc32.c:2683: error: called object is not a function
make[1]: *** [sys_sparc32.o] Error 1

The lines in question are
if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg)))
                  (clen64 > (orig_cmsg_len + wp - workbuf))) {

Is a "||" missing, or something else?

It appears the same lines are in most fixed architectures so probably 
more architectures don't compile.

-- 
Meelis Roos (mroos@linux.ee)

Re: 2.4 compile errors in 32-bit sys_revcmsg fixes

[Stephen Rothwell]

On Tue, 22 Feb 2005 11:48:31 +0200 (EET) Meelis Roos <mroos@linux.ee> wrote:
>
> Is a "||" missing, or something else?

Yes, that's all.  I have already sent a fix to Marcelo.  Sorry for the
inconvenience.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/