RE: [PATCH v3 0/4] Performance improvement of decoder

[jackson.lee <jackson.lee@chipsnmedia.com>]

Hi Nicolas

Can you please review these patch series ?

Thanks


> -----Original Message-----
> From: jackson.lee <jackson.lee@chipsnmedia.com>
> Sent: Monday, July 7, 2025 9:37 AM
> To: mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> nicolas.dufresne@collabora.com; bob.beckett@collabora.com
> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; lafley.kim
> <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; hverkuil@xs4all.nl; Nas
> Chung <nas.chung@chipsnmedia.com>
> Subject: RE: [PATCH v3 0/4] Performance improvement of decoder
> 
> Hi Nicolas
> 
> Can you review these patch series?
> 
> These patch series includes the below changes as well.
> 
> 1. The explanation for change of Fix Null reference while testing fluster
> 2. Reducing the active loop because of overhead and explanation for change
> of Improve performance decoder 3. Making new patch set in order to check
> EINVAL and add a warn_on around it.
> 
> Thanks
> Jackson
> 
> > -----Original Message-----
> > From: jackson.lee <jackson.lee@chipsnmedia.com>
> > Sent: Monday, June 23, 2025 9:22 AM
> > To: mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> > nicolas.dufresne@collabora.com; bob.beckett@collabora.com
> > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
> > jackson.lee <jackson.lee@chipsnmedia.com>; lafley.kim
> > <lafley.kim@chipsnmedia.com>; b- brnich@ti.com; hverkuil@xs4all.nl;
> > Nas Chung <nas.chung@chipsnmedia.com>
> > Subject: [PATCH v3 0/4] Performance improvement of decoder
> >
> > From: Jackson Lee <jackson.lee@chipsnmedia.com>
> >
> > v4l2-compliance results:
> > ========================
> >
> > v4l2-compliance 1.28.1-5233, 64 bits, 64-bit time_t
> >
> > Buffer ioctls:
> >                 warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS
> > not supported
> >                 warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS
> > not supported
> >         test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> >         test CREATE_BUFS maximum buffers: OK
> >         test VIDIOC_EXPBUF: OK
> >         test Requests: OK (Not Supported)
> >
> > Total for wave5-dec device /dev/video0: 46, Succeeded: 46, Failed: 0,
> > Warnings: 2 Total for wave5-enc device /dev/video1: 46, Succeeded: 46,
> > Failed: 0, Warnings: 0
> >
> > Fluster test results:
> > =====================
> >
> > Running test suite JCT-VC-HEVC_V1 with decoder
> > GStreamer-H.265-V4L2-Gst1.0 Using 3 parallel job(s)
> > Ran 133/147 tests successfully               in 40.114 secs
> >
> > (1 test fails because of not supporting to parse multi frames, 1 test
> > fails because of a missing frame and slight corruption,
> >  2 tests fail because of sizes which are incompatible with the IP, 11
> > tests fail because of unsupported 10 bit format)
> >
> >
> > Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0
> > Using 3 parallel job(s)
> > Ran 78/135 tests successfully               in 43.364 secs
> >
> > (57 fail because the hardware is unable to decode  MBAFF / FMO / Field
> > / Extended profile streams.)
> >
> > Running test suite JVT-FR-EXT with decoder GStreamer-H.264-V4L2-Gst1.0
> > Using 3 parallel job(s)
> > Ran 25/69 tests successfully               in 40.411 secs
> >
> > (44 fail because the hardware does not support field encoded and 422
> > encoded stream)
> >
> > Seek test
> > =====================
> > 1. gst-play-1.0 seek.264
> > 2. this will use waylandsink since gst-play-1.0 uses playbin.
> >    if you don't want to hook up display,
> >    you can run gst-play-1.0 seek.264 --videosink=fakevideosink instead 3.
> > Let pipeline run for 2-3 seconds 4. press SPACE key to pause 5. press
> > 0 to reset press SPACE to start again
> >
> > gst-play-1.0 seek.264 --videosink=fakevideosink Press 'k' to see a
> > list of keyboard shortcuts.
> > Now playing /root/seek.264
> > Redistribute latency...
> > Redistribute latency...
> > Redistribute latency...
> > Redistribute latency...
> > Redistribute latency...aused
> > 0:00:09.9 / 0:00:09.7
> > Reached end of play list.
> >
> > Sequence Change test
> > =====================
> > gst-launch-1.0 filesrc location=./drc.h264 ! h264parse ! v4l2h264dec !
> > filesink location=./h264_output_420.yuv Setting pipeline to PAUSED ...
> > Pipeline is PREROLLING ...
> > Redistribute latency...
> > Pipeline is PREROLLED ...
> > Setting pipeline to PLAYING ...
> > New clock: GstSystemClock
> > Redistribute latency...
> > Got EOS from element "pipeline0".
> > Execution ended after 0:00:00.113620590 Setting pipeline to NULL ...
> > Freeing pipeline ...
> >
> > Change since v2:
> > ==================
> > * For [PATCH v3 4/4] media: chips-media: wave5: Improve performance of
> > decoder
> >  - squash v2's #3~#6 to #4 patch of v3
> >
> > Change since v1:
> > ===================
> > * For [PATCH v2 2/7] media: chips-media: wave5: Improve performance of
> > decoder
> >  - change log to dbg level
> >
> > Change since v0:
> > ===================
> > * For [PATCH v1 2/7] media: chips-media: wave5: Improve performance of
> > decoder
> >  - separates the previous patch to a few patches
> >
> > * For [PATCH v1 3/7] media: chips-media: wave5: Fix not to be closed
> >  - separated from the previous patch of performance improvement of
> >    decoder
> >
> > * For [PATCH v1 4/7] media: chips-media: wave5: Use spinlock whenever
> > state is changed
> >  - separated from the previous patch of performance improvement of
> >    decoder
> >
> > * For [PATCH v1 5/7] media: chips-media: wave5: Fix not to free
> > resources normally when
> >     instance was destroyed
> >  - separated from the previous patch of performance improvement of
> >    decoder
> >
> > * For [PATCH v1 7/7] media: chips-media: wave5: Fix SError of kernel
> > panic when closed
> >  - separated from the previous patch of performance improvement of
> >    decoder
> >
> >
> > Jackson Lee (4):
> >   media: chips-media: wave5: Fix SError of kernel panic when closed
> >   media: chips-media: wave5: Fix Null reference while testing fluster
> >   media: chips-media: wave5: Add WARN_ON to check if dec_output_info is
> >     NULL
> >   media: chips-media: wave5: Improve performance of decoder
> >
> >  .../platform/chips-media/wave5/wave5-helper.c |  23 ++-
> >  .../platform/chips-media/wave5/wave5-hw.c     |   2 +-
> >  .../chips-media/wave5/wave5-vpu-dec.c         | 139 ++++++++++++------
> >  .../chips-media/wave5/wave5-vpu-enc.c         |   8 +-
> >  .../platform/chips-media/wave5/wave5-vpu.c    |  71 +++++++--
> >  .../platform/chips-media/wave5/wave5-vpuapi.c |  37 ++---
> >   .../platform/chips-media/wave5/wave5-vpuapi.h |  11 ++
> >  .../chips-media/wave5/wave5-vpuconfig.h       |   1 +
> >  8 files changed, 219 insertions(+), 73 deletions(-)
> >
> > --
> > 2.43.0
>