From: Markus Elfring <Markus.Elfring@web.de>
To: Jackson Lee <jackson.lee@chipsnmedia.com>,
Nas Chung <nas.chung@chipsnmedia.com>,
linux-media@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Brandon Brnich <b-brnich@ti.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Hans Verkuil <hverkuil@xs4all.nl>,
Lafley Kim <lafley.kim@chipsnmedia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Robert Beckett <bob.beckett@collabora.com>
Subject: Re: [PATCH v3 4/4] media: chips-media: wave5: Improve performance of decoder
Date: Tue, 16 Sep 2025 13:21:28 +0200 [thread overview]
Message-ID: <f27c03e0-732b-431f-9127-1da9f0771135@web.de> (raw)
In-Reply-To: <20250623002153.51-5-jackson.lee@chipsnmedia.com>
…
> To archive this goal, the device_run() calls v4l2_m2m_job_finish
…
achieve?
…
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
…
> @@ -1236,6 +1235,11 @@ static void wave5_vpu_dec_buf_queue_src(struct vb2_buffer *vb)
> vbuf->sequence = inst->queued_src_buf_num++;
>
> v4l2_m2m_buf_queue(m2m_ctx, vbuf);
> +
> + INIT_LIST_HEAD(&vpu_buf->list);
> + mutex_lock(&inst->feed_lock);
> + list_add_tail(&vpu_buf->list, &inst->avail_src_bufs);
> + mutex_unlock(&inst->feed_lock);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&inst->feed_lock);”?
https://elixir.bootlin.com/linux/v6.17-rc6/source/include/linux/mutex.h#L228
Regards,
Markus
next prev parent reply other threads:[~2025-09-16 11:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 0:21 [PATCH v3 0/4] Performance improvement " Jackson.lee
2025-06-23 0:21 ` [PATCH v3 1/4] media: chips-media: wave5: Fix SError of kernel panic when closed Jackson.lee
2025-08-29 18:03 ` Nicolas Dufresne
2025-06-23 0:21 ` [PATCH v3 2/4] media: chips-media: wave5: Fix Null reference while testing fluster Jackson.lee
2025-08-29 18:13 ` Nicolas Dufresne
2025-09-09 3:43 ` jackson.lee
2025-06-23 0:21 ` [PATCH v3 3/4] media: chips-media: wave5: Add WARN_ON to check if dec_output_info is NULL Jackson.lee
2025-08-29 18:15 ` Nicolas Dufresne
2025-09-09 3:45 ` jackson.lee
2025-06-23 0:21 ` [PATCH v3 4/4] media: chips-media: wave5: Improve performance of decoder Jackson.lee
2025-08-29 18:01 ` Nicolas Dufresne
2025-09-09 1:42 ` jackson.lee
2025-09-16 11:21 ` Markus Elfring [this message]
2025-07-07 0:37 ` [PATCH v3 0/4] Performance improvement " jackson.lee
2025-08-12 7:51 ` jackson.lee
2025-08-29 15:40 ` Nicolas Dufresne
2025-09-09 6:16 ` jackson.lee
2025-09-09 21:33 ` Nicolas Dufresne
2025-09-10 6:59 ` jackson.lee
2025-09-10 12:56 ` Nicolas Dufresne
2025-09-11 2:04 ` jackson.lee
2025-09-11 12:23 ` Nicolas Dufresne
2025-09-11 4:40 ` jackson.lee
2025-09-15 7:33 ` jackson.lee
2025-09-15 20:14 ` Nicolas Dufresne
2025-09-16 0:40 ` jackson.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27c03e0-732b-431f-9127-1da9f0771135@web.de \
--to=markus.elfring@web.de \
--cc=b-brnich@ti.com \
--cc=bob.beckett@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=jackson.lee@chipsnmedia.com \
--cc=lafley.kim@chipsnmedia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nas.chung@chipsnmedia.com \
--cc=nicolas.dufresne@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®