* [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe()
@ 2020-04-05 9:30 Markus Elfring
2020-04-05 11:49 ` Paul Cercueil
2020-04-07 20:42 ` Paul Cercueil
0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2020-04-05 9:30 UTC (permalink / raw)
To: dri-devel, Daniel Vetter, David Airlie, Paul Cercueil
Cc: LKML, kernel-janitors, Tang Bin
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 11:25:30 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
index 9dfe7cb530e1..06ca752b76ee 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
@@ -661,10 +661,8 @@ static int ingenic_drm_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "Failed to get platform irq");
+ if (irq < 0)
return irq;
- }
if (soc_info->needs_dev_clk) {
priv->lcd_clk = devm_clk_get(dev, "lcd");
--
2.26.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe()
2020-04-05 9:30 [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe() Markus Elfring
@ 2020-04-05 11:49 ` Paul Cercueil
2020-04-07 20:42 ` Paul Cercueil
1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2020-04-05 11:49 UTC (permalink / raw)
To: Markus Elfring
Cc: dri-devel, Daniel Vetter, David Airlie, LKML, kernel-janitors, Tang Bin
Hi,
Le dim. 5 avril 2020 à 11:30, Markus Elfring <Markus.Elfring@web.de> a
écrit :
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 11:25:30 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index 9dfe7cb530e1..06ca752b76ee 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -661,10 +661,8 @@ static int ingenic_drm_probe(struct
> platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "Failed to get platform irq");
> + if (irq < 0)
> return irq;
> - }
>
> if (soc_info->needs_dev_clk) {
> priv->lcd_clk = devm_clk_get(dev, "lcd");
> --
> 2.26.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe()
2020-04-05 9:30 [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe() Markus Elfring
2020-04-05 11:49 ` Paul Cercueil
@ 2020-04-07 20:42 ` Paul Cercueil
1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2020-04-07 20:42 UTC (permalink / raw)
To: Markus Elfring
Cc: dri-devel, Daniel Vetter, David Airlie, LKML, kernel-janitors, Tang Bin
Hi Markus,
Le dim. 5 avril 2020 à 11:30, Markus Elfring <Markus.Elfring@web.de> a
écrit :
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 11:25:30 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied to drm-misc-next, thanks.
-Paul
> ---
> drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index 9dfe7cb530e1..06ca752b76ee 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -661,10 +661,8 @@ static int ingenic_drm_probe(struct
> platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "Failed to get platform irq");
> + if (irq < 0)
> return irq;
> - }
>
> if (soc_info->needs_dev_clk) {
> priv->lcd_clk = devm_clk_get(dev, "lcd");
> --
> 2.26.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-07 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-05 9:30 [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe() Markus Elfring
2020-04-05 11:49 ` Paul Cercueil
2020-04-07 20:42 ` Paul Cercueil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®