mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: geert <geert@linux-m68k.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	biju.das.au <biju.das.au@gmail.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: RE: [PATCH 3/7] ASoC: renesas: rz-ssi: Use dev variable in probe()
Date: Thu, 13 Nov 2025 10:33:29 +0000	[thread overview]
Message-ID: <TY3PR01MB1134642CDDC50ACE32250020686CDA@TY3PR01MB11346.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXqBOpczZ-Kw64AQODSh0Q8HEAzBseUjwD7TO+dKq9==g@mail.gmail.com>

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 13 November 2025 08:48
> Subject: Re: [PATCH 3/7] ASoC: renesas: rz-ssi: Use dev variable in probe()
> 
> Hi Biju,
> 
> On Thu, 13 Nov 2025 at 09:02, Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > >
> > > > Replace '&pdev->dev'->dev in probe(), this makes few error paths shorter.
> > >
> > > nitpick
> > >
> > > '&pdev->dev'->'dev' ?
> 
> Woow, that "->"-pipeline looks confusing ;-)
> 
> >
> > OK, will fix this.
> 
> Please use English where it makes sense:
> 
>     Replace <foo> by <bar> ...

Ok, will use Replace '&pdev->dev' by 'dev'.

Cheers,
Biju

  reply	other threads:[~2025-11-13 10:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 15:41 [PATCH 0/7] RZ/G2L SSI Improvements Biju
2025-11-12 15:41 ` [PATCH 1/7] ASoC: renesas: rz-ssi: Fix channel swap issue in full duplex mode Biju
2025-11-13  5:50   ` Kuninori Morimoto
2025-11-13  8:01     ` Biju Das
2025-11-12 15:41 ` [PATCH 2/7] ASoC: renesas: rz-ssi: Fix rz_ssi_priv::hw_params_cache::sample_width Biju
2025-11-13  5:51   ` Kuninori Morimoto
2025-11-12 15:41 ` [PATCH 3/7] ASoC: renesas: rz-ssi: Use dev variable in probe() Biju
2025-11-13  5:50   ` Kuninori Morimoto
2025-11-13  8:02     ` Biju Das
2025-11-13  8:47       ` Geert Uytterhoeven
2025-11-13 10:33         ` Biju Das [this message]
2025-11-12 15:41 ` [PATCH 4/7] ASoC: renesas: rz-ssi: Remove trailing comma in the terminator entry Biju
2025-11-13  5:51   ` Kuninori Morimoto
2025-11-12 15:41 ` [PATCH 5/7] ASoC: renesas: rz-ssi: Move DMA configuration Biju
2025-11-12 15:41 ` [PATCH 6/7] ASoC: renesas: rz-ssi: Add support for 24 bits sample width Biju
2025-11-13  5:56   ` Kuninori Morimoto
2025-11-13  8:04     ` Biju Das
2025-11-12 15:41 ` [PATCH 7/7] ASoC: renesas: rz-ssi: Add support for 32 " Biju
2025-11-12 16:25 ` [PATCH 0/7] RZ/G2L SSI Improvements Mark Brown
2025-11-13  5:49 ` Kuninori Morimoto
2025-11-13  7:58   ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY3PR01MB1134642CDDC50ACE32250020686CDA@TY3PR01MB11346.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=biju.das.au@gmail.com \
    --cc=broonie@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®